p2p: avoid calculating onion address checksum when version is not 3
ClosedPublic
Actions

Authored by PiRK on Dec 23 2021, 09:21.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC2ed0e4c8158d: p2p: avoid calculating onion address checksum when version is not 3

Summary

There is no need to calculate the full checksum for an Tor v3 onion address if the version byte is not the expected one.

This is a backport of core#20405

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr20405

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17743
Build 35312: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 35311: arc lint + arc unit

Event Timeline

PiRK created this revision.Dec 23 2021, 09:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 23 2021, 09:21

PiRK requested review of this revision.Dec 23 2021, 09:22

teamcity edited the summary of this revision. (Show Details)Dec 23 2021, 09:22

Harbormaster completed remote builds in B17743: Diff 31558.Dec 23 2021, 09:38

Fabien accepted this revision.Dec 23 2021, 10:24

This revision is now accepted and ready to land.Dec 23 2021, 10:24

Closed by commit rABC2ed0e4c8158d: p2p: avoid calculating onion address checksum when version is not 3 (authored by lontivero <lucasontivero@gmail.com>, committed by PiRK). · Explain WhyDec 23 2021, 13:52

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC2ed0e4c8158d: p2p: avoid calculating onion address checksum when version is not 3.

Revision Contents
Changeset List

Path

Size

src/

netaddress.cpp

7 lines

Diff 31558

View Options

p2p: avoid calculating onion address checksum when version is not 3ClosedPublicActions