qt, wallet: Remove unused AskPassphraseDialog::Decrypt
ClosedPublic
Actions

Authored by PiRK on Dec 23 2021, 14:04.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC01d89460d994: qt, wallet: Remove unused AskPassphraseDialog::Decrypt

Summary

Co-authored-by: Sehyun Chung <sehyun@berkeley.edu>

This is a backport of core-gui#109 [1/3]
https://github.com/bitcoin-core/gui/pull/109/commits/6e950118a31fd6a85026d934fc6adb6255e47e23

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17748
Build 35322: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 35321: arc lint + arc unit

Event Timeline

PiRK created this revision.Dec 23 2021, 14:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 23 2021, 14:04

PiRK requested review of this revision.Dec 23 2021, 14:04

teamcity edited the summary of this revision. (Show Details)Dec 23 2021, 14:04

PiRK edited the summary of this revision. (Show Details)Dec 23 2021, 14:05

PiRK mentioned this in D10739: qt, wallet: Drop unused parameter in WalletModel::setWalletEncrypted.Dec 23 2021, 14:12

Run arc lint src/qt/askpassphrasedialog.cpp
For some reason, arc lint without specifying the file path did not detect this change until the next time the file is touched in D10739

Harbormaster completed remote builds in B17748: Diff 31571.Dec 23 2021, 14:30

Fabien accepted this revision.Dec 23 2021, 14:43

This revision is now accepted and ready to land.Dec 23 2021, 14:43

Harbormaster completed remote builds in B17751: Diff 31574.Dec 23 2021, 14:48

Closed by commit rABC01d89460d994: qt, wallet: Remove unused AskPassphraseDialog::Decrypt (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyDec 23 2021, 17:05

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC01d89460d994: qt, wallet: Remove unused AskPassphraseDialog::Decrypt.

PiRK mentioned this in D10831: qt: unlock wallet "OK" button bugfix.Jan 15 2022, 12:21

PiRK mentioned this in rABC4fc92bdfa77d: qt: unlock wallet "OK" button bugfix.Jan 17 2022, 12:29