fix mismatching arg names in avalanche RPC commands
ClosedPublic
Actions

Authored by PiRK on Dec 23 2021, 16:03.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCdee7f9966a6c: fix mismatching arg names in avalanche RPC commands

Summary

This makes the arg names identical in the RPC function and in the corresponding registered command.

In the next commit, an assertion will be added to avoid any future similar regression.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17754
Build 35334: Build Diff	build-without-wallet · build-diff · build-debug · build-clang · lint-circular-dependencies · build-clang-tidy
Build 35333: arc lint + arc unit

Event Timeline

PiRK created this revision.Dec 23 2021, 16:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 23 2021, 16:03

PiRK requested review of this revision.Dec 23 2021, 16:03

PiRK retitled this revision from fix matching rg names in avalanche RPC commands to fix mismatching arg names in avalanche RPC commands.Dec 23 2021, 16:03

PiRK added a child revision: D10742: Assert that RPCArg names are equal to CRPCCommand ones (abc, avalanche).Dec 23 2021, 16:08

Harbormaster completed remote builds in B17754: Diff 31577.Dec 23 2021, 16:14

Fabien accepted this revision.Jan 3 2022, 07:13

This revision is now accepted and ready to land.Jan 3 2022, 07:13

Closed by commit rABCdee7f9966a6c: fix mismatching arg names in avalanche RPC commands (authored by PiRK). · Explain WhyJan 3 2022, 14:07

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCdee7f9966a6c: fix mismatching arg names in avalanche RPC commands.