Paths

Table of Contentst

Differential D10743

remove dead rpc code
ClosedPublic
Actions

Authored by PiRK on Dec 23 2021, 16:57.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCe74ec8b0f2fa: remove dead rpc code

Summary

Checking for fHelp, or the size of the args, is dead code because:

fHelp is always false (src/qt/test/rpcnestedtests.cpp)
It is already implicitly called by RPCHelpMan::Check (src/rpc/mining.cpp, src/rpc/misc.cpp, src/rpc/net.cpp)

This is a backport of core#18531 [1/2]
https://github.com/bitcoin/bitcoin/pull/18531/commits/fa19bb2cd8c575593583138a84e6bb3444d6196d

I confirmed with a grep that fHelp is not used in any other RPC command.

Depends on D10742

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17757
Build 35340: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang · build-clang-tidy
Build 35339: arc lint + arc unit

Event Timeline

PiRK created this revision.Dec 23 2021, 16:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 23 2021, 16:57

PiRK requested review of this revision.Dec 23 2021, 16:57

teamcity edited the summary of this revision. (Show Details)Dec 23 2021, 16:58

PiRK edited the summary of this revision. (Show Details)Dec 23 2021, 16:58

PiRK added a parent revision: D10742: Assert that RPCArg names are equal to CRPCCommand ones (abc, avalanche).

PiRK added a child revision: D10744: remove CRPCCommand constructor that takes rpcfn_type function pointer.Dec 23 2021, 17:04

Harbormaster completed remote builds in B17757: Diff 31580.Dec 23 2021, 17:14

Fabien accepted this revision.Jan 3 2022, 07:24

This revision is now accepted and ready to land.Jan 3 2022, 07:24

Closed by commit rABCe74ec8b0f2fa: remove dead rpc code (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyJan 3 2022, 14:08

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCe74ec8b0f2fa: remove dead rpc code.

Revision Contents
Changeset List

Path

Size

src/

qt/

test/

rpcnestedtests.cpp

3 lines

rpc/

8 lines

4 lines

8 lines

Diff 31580

src/qt/test/rpcnestedtests.cpp

Loading...

src/rpc/mining.cpp

Loading...

src/rpc/misc.cpp

Loading...

src/rpc/net.cpp

Loading...