Differential D10802

Deduplicate deprecation tests
ClosedPublic
Actions

Authored by Fabien on Jan 10 2022, 13:53.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC04e01dec2d1c: Deduplicate deprecation tests

Summary

Some of the deprecation tests are currently duplicated between 2 different functional tests. This diffs moves all the test deprecated fields into rpc_deprecated where they belong, also adding a missing case.

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 10 2022, 13:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 10 2022, 13:54

Fabien requested review of this revision.Jan 10 2022, 13:54

Fabien added a child revision: D10803: Remove the deprecated banscore field from the getpeerinfo RPC.Jan 10 2022, 14:14

Harbormaster completed remote builds in B17858: Diff 31725.Jan 10 2022, 14:23

PiRK accepted this revision.Jan 10 2022, 14:40

This revision is now accepted and ready to land.Jan 10 2022, 14:40

Closed by commit rABC04e01dec2d1c: Deduplicate deprecation tests (authored by Fabien). · Explain WhyJan 10 2022, 15:06

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC04e01dec2d1c: Deduplicate deprecation tests.

Revision Contents
Changeset List

Path

Size

test/

functional/

rpc_deprecated.py

13 lines

rpc_getpeerinfo_deprecation.py

Diff 31730

View Options

test/functional/rpc_deprecated.py