Replace hardcoded future block time with preexisting constant
ClosedPublic
Actions

Authored by jasonbcox on Feb 11 2018, 19:17.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING8929e651a59d: Replace hardcoded future block time with preexisting constant
rABC8929e651a59d: Replace hardcoded future block time with preexisting constant

Summary

Hard coded magic numbers are bad. Preexisting constant:
./chain.h:23:static const int64_t MAX_FUTURE_BLOCK_TIME = 2 * 60 * 60;

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

future

Lint

Lint Passed

Severity	Location	Code	Message
Auto-Fix	src/init.cpp:1	CFMT	Code style violation

Unit

No Test Coverage

Build Status

Buildable 1828
Build 1847: Bitcoin ABC Buildbot (legacy)
Build 1846: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Feb 11 2018, 19:17

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 11 2018, 19:17

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B1828: Diff 2844.Feb 11 2018, 19:41

deadalnix accepted this revision.Feb 13 2018, 00:13

This revision is now accepted and ready to land.Feb 13 2018, 00:13

Closed by commit rABC8929e651a59d: Replace hardcoded future block time with preexisting constant (authored by jasonbcox). · Explain WhyFeb 18 2018, 01:11

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

init.cpp

4 lines

Diff 2844

View Options

Replace hardcoded future block time with preexisting constantClosedPublicActions