Page MenuHomePhabricator

qt: unlock wallet "OK" button bugfix
ClosedPublic

Authored by PiRK on Jan 15 2022, 12:21.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC4fc92bdfa77d: qt: unlock wallet "OK" button bugfix
Summary

When trying to send a transaction from an encrypted wallet, the ask passphrase dialog would not allow the user to click the "OK" button and proceed. Therefore it was impossible to send a transaction through the gui. It was not enabling the "OK" button after the passphrase was entered by the user, because it was using the same form validation logic as the "Change passphrase" flow.

This bug was introduced in D10737 (v0.24.7).

This is a backport of core-gui#138

Test Plan

In bitcoin-qt, try to send a transaction using an encrypted wallet. Verify that the "OK" button is not disabled in the passphrase dialog after typing at least one character in the passphrase field.

Event Timeline

This needs to be rebased after bumping the version to 0.24.10.

PiRK published this revision for review.Jan 17 2022, 07:17
Fabien added a subscriber: Fabien.
Fabien added inline comments.
doc/release-notes.md
8 ↗(On Diff #31823)

Nit, can you rephrase to avoid the commas ? Like:

Fix a bug introduced in version 0.24.7 that caused the "OK" button to stay disabled in the GUI's passphrase dialog when sending a transaction from an encrypted wallet.
This revision is now accepted and ready to land.Jan 17 2022, 09:13

rephrase release note in the present tense without comma