qt: unlock wallet "OK" button bugfix
ClosedPublic
Actions

Authored by PiRK on Jan 15 2022, 12:21.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC4fc92bdfa77d: qt: unlock wallet "OK" button bugfix

Summary

When trying to send a transaction from an encrypted wallet, the ask passphrase dialog would not allow the user to click the "OK" button and proceed. Therefore it was impossible to send a transaction through the gui. It was not enabling the "OK" button after the passphrase was entered by the user, because it was using the same form validation logic as the "Change passphrase" flow.

This bug was introduced in D10737 (v0.24.7).

This is a backport of core-gui#138

Test Plan

In bitcoin-qt, try to send a transaction using an encrypted wallet. Verify that the "OK" button is not disabled in the passphrase dialog after typing at least one character in the passphrase field.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

gui_pr138

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17918
Build 35659: Build Diff	build-debug · build-without-wallet · build-diff · lint-circular-dependencies · build-clang-tidy · build-clang
Build 35658: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 15 2022, 12:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 15 2022, 12:21

teamcity edited the summary of this revision. (Show Details)Jan 15 2022, 12:21

This needs to be rebased after bumping the version to 0.24.10.

Harbormaster completed remote builds in B17918: Diff 31818.Jan 15 2022, 12:34

rebase and rephrase

PiRK published this revision for review.Jan 17 2022, 07:17

Harbormaster completed remote builds in B17923: Diff 31823.Jan 17 2022, 07:31

Fabien accepted this revision.Jan 17 2022, 09:13

Fabien added a subscriber: Fabien.

Fabien added inline comments.

doc/release-notes.md
8 ↗	(On Diff #31823)	Nit, can you rephrase to avoid the commas ? Like: Fix a bug introduced in version 0.24.7 that caused the "OK" button to stay disabled in the GUI's passphrase dialog when sending a transaction from an encrypted wallet.