Paths

Table of Contentst

Differential D10842

refactor: Make CTxMemPool::m_check_ratio a const and a constructor argument
ClosedPublic
Actions

Authored by PiRK on Jan 19 2022, 15:11.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCae6af22fb10f: refactor: Make CTxMemPool::m_check_ratio a const and a constructor argument

Summary

Since m_check_ratio is only set once and since the CTxMemPool object is
no longer a global variable, m_check_ratio can be passed into the
constructor of CTxMemPool. Since it is only read from after
initialization, m_check_ratio can also be made a const and hence no
longer needs to be guarded by the cs mutex.

This is a backport of core#20222 [2/3]
https://github.com/bitcoin/bitcoin/pull/20222/commits/e3310692d0e9720e960b9785274ce1f0b58b4cd7

Depends on D10841

Test Plan

With TSAN:
ninja && ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17937
Build 35696: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang · build-clang-tidy
Build 35695: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 19 2022, 15:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 19 2022, 15:11

PiRK requested review of this revision.Jan 19 2022, 15:11

teamcity edited the summary of this revision. (Show Details)Jan 19 2022, 15:11

PiRK added a child revision: D10843: refactor: Clean up CTxMemPool initializer list.Jan 19 2022, 15:13

PiRK added a child revision: D10844: locks: Annotate CTxMemPool::check to require cs_main.Jan 19 2022, 15:19

Harbormaster completed remote builds in B17937: Diff 31842.Jan 19 2022, 15:31

Fabien accepted this revision.Jan 19 2022, 16:44

This revision is now accepted and ready to land.Jan 19 2022, 16:44

Closed by commit rABCae6af22fb10f: refactor: Make CTxMemPool::m_check_ratio a const and a constructor argument (authored by Elle Mouton <elle.mouton@gmail.com>, committed by PiRK). · Explain WhyJan 19 2022, 17:21

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCae6af22fb10f: refactor: Make CTxMemPool::m_check_ratio a const and a constructor argument.

Revision Contents
Changeset List

Path

Size

src/

20 lines

test/

util/

setup_common.cpp

3 lines

14 lines

12 lines

Diff 31842

src/init.cpp

Loading...

src/test/util/setup_common.cpp

Loading...

src/txmempool.h

Loading...

src/txmempool.cpp

Loading...