[Cashtab] Add bg color ant select-selector
ClosedPublic
Actions

Authored by kieran709 on Jan 19 2022, 16:04.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC45d0c6fd9ea8: [Cashtab] Add bg color ant select-selector

Summary

Related to task T2177, bg color needs to be added to ant-select-selector in EnhancedInputs.js.

Test Plan

cd web/cashtab
npm start
ensure that drop down menus in Send.js and Configure.js have an appropriate bg color and that content is legible

Diff Detail

Repository

rABC Bitcoin ABC

Branch

add-bg-color-ant-select

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17941
Build 35704: Build Diff	cashtab-tests
Build 35703: arc lint + arc unit

Event Timeline

kieran709 created this revision.Jan 19 2022, 16:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 19 2022, 16:04

kieran709 requested review of this revision.Jan 19 2022, 16:04

Harbormaster completed remote builds in B17941: Diff 31846.Jan 19 2022, 16:08

bytesofman requested changes to this revision.Jan 20 2022, 17:02

bytesofman added inline comments.

web/cashtab/src/components/Common/EnhancedInputs.js
52	This changes the color from white to grey. This diff should keep the color constant. Is there a reason you are not using `props.theme.forms.selectionBackground` (which already seems to be applied to this component)? What color are you trying to control here?

This revision now requires changes to proceed.Jan 20 2022, 17:02

Responding to review feedback, changed reference in EnhancedInputs.js at line 52 to selectionBackground. Added inline comment to give better understanding of what color I am trying to change. Updated snapshots.

Harbormaster completed remote builds in B17960: Diff 31878.Jan 20 2022, 18:09

kieran709 added inline comments.Jan 20 2022, 18:17

web/cashtab/src/components/Common/EnhancedInputs.js
52	This comment lead me to realizing that my monitor was not callibrated right because I could not see the difference in the two colors. I am trying to change the background and foreground color of the following input: Without the added reference here, all of the other inputs change color, but not this one.