Paths

Table of Contentst

Differential D10853

doc, test: Improve setup_clean_chain documentation
ClosedPublic
Actions

Authored by Fabien on Jan 20 2022, 15:24.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC10b46554f403: doc, test: Improve setup_clean_chain documentation

Summary

The first commit improves documentation on setup_clean_chain which is misunderstood quite frequently. Most importantly it fixes the TestShell docs which are simply incorrect.

The second commit removes the instances of setup_clean_clain in functional tests where it is not changing the default.

Backport of core#21042.

Test Plan

ninja check-functional-extended

In test/functional, run:

git grep 'self.setup_clean_chain = False'

and check the is no occurrence in the test outside of the framework itself.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 20 2022, 15:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 20 2022, 15:24

Fabien requested review of this revision.Jan 20 2022, 15:24

teamcity edited the summary of this revision. (Show Details)Jan 20 2022, 15:25

Harbormaster completed remote builds in B17951: Diff 31868.Jan 20 2022, 15:38

PiRK accepted this revision.Jan 20 2022, 17:08

This revision is now accepted and ready to land.Jan 20 2022, 17:08

Closed by commit rABC10b46554f403: doc, test: Improve setup_clean_chain documentation (authored by Fabien). · Explain WhyJan 20 2022, 20:04

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC10b46554f403: doc, test: Improve setup_clean_chain documentation.

Revision Contents
Changeset List

Path

Size

doc/

functional-tests.md

11 lines

test-shell.md

2 lines

test/

functional/

abc-cmdline.py

1 line

abc-invalid-message.py

1 line

abc-version-message.py

1 line

example_test.py

5 lines

feature_asmap.py

1 line

feature_dbcrash.py

1 line

feature_includeconf.py

1 line

p2p_add_connections.py

1 line

p2p_addr_relay.py

1 line

p2p_blocksonly.py

1 line

p2p_filter.py

1 line

p2p_getaddr_caching.py

1 line

p2p_inv_download.py

1 line

p2p_invalid_locator.py

1 line

rpc_psbt.py

1 line

wallet_avoidreuse.py

1 line

wallet_createwallet.py

1 line

wallet_watchonly.py

1 line

Diff 31881

View Options

doc/functional-tests.md

View Options

doc/test-shell.md

View Options

test/functional/abc-cmdline.py

View Options

test/functional/abc-invalid-message.py

View Options

test/functional/abc-version-message.py

View Options

test/functional/example_test.py

View Options

test/functional/feature_asmap.py

View Options

test/functional/feature_dbcrash.py

View Options

test/functional/feature_includeconf.py

View Options

test/functional/p2p_add_connections.py

View Options

test/functional/p2p_addr_relay.py

View Options

test/functional/p2p_blocksonly.py

View Options

test/functional/p2p_filter.py

View Options

test/functional/p2p_getaddr_caching.py

View Options

test/functional/p2p_inv_download.py

View Options

test/functional/p2p_invalid_locator.py

View Options

test/functional/rpc_psbt.py

View Options

test/functional/wallet_avoidreuse.py

View Options

test/functional/wallet_createwallet.py

View Options

test/functional/wallet_watchonly.py

doc, test: Improve setup_clean_chain documentationClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 31881

doc/functional-tests.md

doc/test-shell.md

test/functional/abc-cmdline.py

test/functional/abc-invalid-message.py

test/functional/abc-version-message.py

test/functional/example_test.py

test/functional/feature_asmap.py

test/functional/feature_dbcrash.py

test/functional/feature_includeconf.py

test/functional/p2p_add_connections.py

test/functional/p2p_addr_relay.py

test/functional/p2p_blocksonly.py

test/functional/p2p_filter.py

test/functional/p2p_getaddr_caching.py

test/functional/p2p_inv_download.py

test/functional/p2p_invalid_locator.py

test/functional/rpc_psbt.py

test/functional/wallet_avoidreuse.py

test/functional/wallet_createwallet.py

test/functional/wallet_watchonly.py

doc, test: Improve setup_clean_chain documentation
ClosedPublic
Actions

Revision Contents
Changeset List