Differential D10854

Increase the timeout for sending a large block in abc_p2p_fullblocktest
ClosedPublic
Actions

Authored by Fabien on Jan 20 2022, 15:58.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC4d1de89a3dd1: Increase the timeout for sending a large block in abc_p2p_fullblocktest

Summary

This test fails sometimes due to a timeout on the TSAN or OSX builds.
The timeout has already been bumped for RPC submission, so do the same for p2p submission. Worst case the test takes longer to fail (if there is a deadlock) which is annoying, but will clearly indicate the source is not resource exhaustion. In the best case this fixes the flakyness.

Test Plan

With TSAN:

./test/functional/test_runner.py abc_p2p_fullblocktest

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 20 2022, 15:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 20 2022, 15:58

Fabien requested review of this revision.Jan 20 2022, 15:58

@bot build-tsan

teamcity awarded a token.Jan 20 2022, 15:59

Harbormaster completed remote builds in B17952: Diff 31869.Jan 20 2022, 16:13

PiRK accepted this revision.Jan 20 2022, 17:09

This revision is now accepted and ready to land.Jan 20 2022, 17:09

Closed by commit rABC4d1de89a3dd1: Increase the timeout for sending a large block in abc_p2p_fullblocktest (authored by Fabien). · Explain WhyJan 20 2022, 20:04

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC4d1de89a3dd1: Increase the timeout for sending a large block in abc_p2p_fullblocktest.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc_p2p_fullblocktest.py

2 lines

Diff 31882

View Options

test/functional/abc_p2p_fullblocktest.py

Increase the timeout for sending a large block in abc_p2p_fullblocktestClosedPublicActions