Paths

Table of Contentst

Differential D10855

util: Make Assume() usable as unary expression
ClosedPublic
Actions

Authored by PiRK on Jan 20 2022, 16:53.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC594794938f9e: util: Make Assume() usable as unary expression

Summary

Assume shouldn't behave different at the call site depending on build flags. Currently compilation fails if it is used as expression. Fix that by using the lambda approach from Assert() without the assert().

This is a backport of core#21317

Test Plan

ninja && ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 20 2022, 16:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 20 2022, 16:53

PiRK requested review of this revision.Jan 20 2022, 16:53

teamcity edited the summary of this revision. (Show Details)Jan 20 2022, 16:53

PiRK added a child revision: D10857: addrman: Improve performance of Good.Jan 20 2022, 17:02

Harbormaster completed remote builds in B17953: Diff 31870.Jan 20 2022, 17:09

Thats not the good PR

This revision now requires changes to proceed.Jan 21 2022, 08:39

PR number fixed

Fabien accepted this revision.Jan 21 2022, 09:45

This revision is now accepted and ready to land.Jan 21 2022, 09:45

Closed by commit rABC594794938f9e: util: Make Assume() usable as unary expression (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyJan 21 2022, 10:08

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC594794938f9e: util: Make Assume() usable as unary expression.

Revision Contents
Changeset List

Path

Size

src/

test/

util_tests.cpp

3 lines

util/

check.h

6 lines

Diff 31889

View Options

src/test/util_tests.cpp