Page MenuHomePhabricator

[refactor] [net] Clean up InactivityCheck()
ClosedPublic

Authored by Fabien on Jan 24 2022, 20:44.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABCa06ab3bb4cb1: [refactor] [net] Clean up InactivityCheck()
Summary
This is a pure refactor and should not change any behavior. It clarifies and documents the InactivityCheck() function

This makes #20721 easier to review. In particular, this function uses a mixture of (unmockable) system time and mockable time. It's important to understand where those are being used when reviewing #20721.

Backport of core#20927.

Ref T1696.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Jan 24 2022, 20:44
This revision is now accepted and ready to land.Jan 25 2022, 08:29