HomePhabricator

[refactor] [net] Clean up InactivityCheck()

Description

[refactor] [net] Clean up InactivityCheck()

Summary:

This is a pure refactor and should not change any behavior. It clarifies and documents the InactivityCheck() function

This makes #20721 easier to review. In particular, this function uses a mixture of (unmockable) system time and mockable time. It's important to understand where those are being used when reviewing #20721.

Backport of core#20927.

Ref T1696.

Test Plan:

ninja all check-all

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Maniphest Tasks: T1696

Differential Revision: https://reviews.bitcoinabc.org/D10874

Details

Provenance
John Newbery <john@johnnewbery.com>Authored on Jan 6 2021, 11:07
FabienCommitted on Jan 25 2022, 09:06
FabienPushed on Jan 25 2022, 09:06
Reviewer
Restricted Project
Differential Revision
D10874: [refactor] [net] Clean up InactivityCheck()
Parents
rABC801711555788: [Cashtab] Improve error handling in validation.js
Branches
Unknown
Tags
Unknown
Tasks
Restricted Maniphest Task

Event Timeline

Fabien added a task: Restricted Maniphest Task.