Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABC13db67570818: net: Move SocketSendData lock annotation to header

Summary

Also, add lock annotation to SendMessages

Can be reviewed with "--word-diff-regex=."

Completes backport of core#20864:
https://github.com/bitcoin/bitcoin/pull/20864/commits/fa210689e27b0d78b2fe894e51e364179db7a3ce

Depends on D10880.

Ref T1696.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 25 2022, 09:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 25 2022, 09:20

Fabien requested review of this revision.Jan 25 2022, 09:20

teamcity edited the summary of this revision. (Show Details)Jan 25 2022, 09:20

Fabien added a child revision: D10882: net, net_processing: move NetEventsInterface method docs to net.h.Jan 25 2022, 09:34

Harbormaster completed remote builds in B17991: Diff 31933.Jan 25 2022, 09:43

PiRK accepted this revision.Jan 25 2022, 10:40

This revision is now accepted and ready to land.Jan 25 2022, 10:40

Closed by commit rABC13db67570818: net: Move SocketSendData lock annotation to header (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyJan 25 2022, 12:52

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC13db67570818: net: Move SocketSendData lock annotation to header.

net: Move SocketSendData lock annotation to header
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 31943

src/net.h

src/net.cpp

net: Move SocketSendData lock annotation to headerClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 31943

src/net.h

src/net.cpp

net: Move SocketSendData lock annotation to header
ClosedPublic
Actions

Revision Contents
Changeset List