Differential D10887

net_processing: split PeerManager into interface and implementation classes
ClosedPublic
Actions

Authored by Fabien on Jan 25 2022, 14:00.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABCbb213e6dee15: net_processing: split PeerManager into interface and implementation classes

Summary

Partial backport of core#20811:
https://github.com/bitcoin/bitcoin/pull/20811/commits/a568b82febb3ecbd5ebb7c3f9da27e762b0c68f6

Note that the cpp file deserves a good reordering, but that's out of scope for this diff.

Depends on D10886.

Ref T1696.

Test Plan

ninja all check-all
ninja bitcoin-fuzzers

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 25 2022, 14:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 25 2022, 14:00

Fabien requested review of this revision.Jan 25 2022, 14:00

teamcity edited the summary of this revision. (Show Details)Jan 25 2022, 14:00

teamcity edited the summary of this revision. (Show Details)Jan 25 2022, 14:05

Fabien added a child revision: D10890: net_processing: move PeerManagerImpl into cpp file.Jan 25 2022, 14:15

Harbormaster completed remote builds in B17999: Diff 31948.Jan 25 2022, 14:16

PiRK edited the summary of this revision. (Show Details)Jan 25 2022, 14:25

PiRK accepted this revision.Jan 25 2022, 14:32

This revision is now accepted and ready to land.Jan 25 2022, 14:32

Closed by commit rABCbb213e6dee15: net_processing: split PeerManager into interface and implementation classes (authored by Fabien). · Explain WhyJan 25 2022, 14:49

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCbb213e6dee15: net_processing: split PeerManager into interface and implementation classes.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

test/

2 lines

8 lines

82 lines

124 lines

test/

denialofservice_tests.cpp

8 lines

util/

setup_common.cpp

2 lines

test/

sanitizer_suppressions/

tsan

2 lines

Diff 31955

View Options

src/avalanche/test/processor_tests.cpp

View Options

src/init.cpp

View Options

src/net_processing.h

View Options

src/net_processing.cpp

View Options

src/test/denialofservice_tests.cpp

View Options

src/test/util/setup_common.cpp

View Options

test/sanitizer_suppressions/tsan

net_processing: split PeerManager into interface and implementation classesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 31955

src/avalanche/test/processor_tests.cpp

src/init.cpp

src/net_processing.h

src/net_processing.cpp

src/test/denialofservice_tests.cpp

src/test/util/setup_common.cpp

test/sanitizer_suppressions/tsan

net_processing: split PeerManager into interface and implementation classes
ClosedPublic
Actions

Revision Contents
Changeset List