test: Use Popen.wait instead of RPC in assert_start_raises_init_error
ClosedPublic
Actions

Authored by PiRK on Jan 25 2022, 16:56.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC598b609c9bbd: test: Use Popen.wait instead of RPC in assert_start_raises_init_error

Summary

Using RPC (wait_for_rpc_connection) has several issue:
 It polls in a loop, which might be slow
It tries to read the RPC cookie file, which might not be present, thus leading to intermittent issues
Fix both by using Popen.wait

This is a backport of core#20613

Test Plan

ninja check-functional-extended

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 25 2022, 16:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 25 2022, 16:56

PiRK requested review of this revision.Jan 25 2022, 16:56

teamcity edited the summary of this revision. (Show Details)Jan 25 2022, 16:56

Harbormaster completed remote builds in B18013: Diff 31969.Jan 25 2022, 17:18

Fabien accepted this revision.Jan 25 2022, 17:59

This revision is now accepted and ready to land.Jan 25 2022, 17:59

Closed by commit rABC598b609c9bbd: test: Use Popen.wait instead of RPC in assert_start_raises_init_error (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyJan 26 2022, 07:27

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC598b609c9bbd: test: Use Popen.wait instead of RPC in assert_start_raises_init_error.

Revision Contents
Changeset List

Path

Size

test/

functional/

test_framework/

test_node.py

20 lines

Diff 31980

View Options

test/functional/test_framework/test_node.py

test: Use Popen.wait instead of RPC in assert_start_raises_init_errorClosedPublicActions