HomePhabricator

test: Use Popen.wait instead of RPC in assert_start_raises_init_error

Description

test: Use Popen.wait instead of RPC in assert_start_raises_init_error

Summary:

Using RPC (wait_for_rpc_connection) has several issue:

 It polls in a loop, which might be slow
It tries to read the RPC cookie file, which might not be present, thus leading to intermittent issues

Fix both by using Popen.wait

This is a backport of core#20613

Test Plan: ninja check-functional-extended

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D10897

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Dec 10 2020, 11:35
PiRKCommitted on Jan 26 2022, 07:27
PiRKPushed on Jan 26 2022, 07:27
Reviewer
Restricted Project
Differential Revision
D10897: test: Use Popen.wait instead of RPC in assert_start_raises_init_error
Parents
rABC0c0123b0aa87: test: fix timeout decrease in feature_assumevalid
Branches
Unknown
Tags
Unknown