Page MenuHomePhabricator
Differential D10924

Remove unused access to addpeeraddress RPC output dict element
ClosedPublic
Actions

Authored by Fabien on Jan 28 2022, 10:35.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC8ee3efcb12e9: Remove unused access to addpeeraddress RPC output dict element
Summary

The ["success"] is unused and causing confusion. It may indicate a missing assert which is not the case here as some addresses are expected to fail, and the total number is asserted after the loop.

Test Plan
./test/functional/test_runner.py abc-cmdline

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 28 2022, 10:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 28 2022, 10:36
Fabien requested review of this revision.Jan 28 2022, 10:36
PiRK accepted this revision.Jan 28 2022, 10:38
This revision is now accepted and ready to land.Jan 28 2022, 10:38
This revision was landed with ongoing or failed builds.Jan 28 2022, 10:44
Closed by commit rABC8ee3efcb12e9: Remove unused access to addpeeraddress RPC output dict element (authored by Fabien). · Explain Why
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC8ee3efcb12e9: Remove unused access to addpeeraddress RPC output dict element.
Harbormaster completed remote builds in B18048: Diff 32038.Jan 28 2022, 11:05

Revision Contents
Changeset List

PathSize
test/
functional/
2 lines

Diff 32039

View Options

test/functional/abc-cmdline.py

Loading...