Page MenuHomePhabricator

Remove unused access to addpeeraddress RPC output dict element
ClosedPublic

Authored by Fabien on Jan 28 2022, 10:35.

Details

Summary

The ["success"] is unused and causing confusion. It may indicate a missing assert which is not the case here as some addresses are expected to fail, and the total number is asserted after the loop.

Test Plan
./test/functional/test_runner.py abc-cmdline

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_unused_success_field
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18048
Build 35918: Build Diffbuild-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 35917: arc lint + arc unit

Event Timeline

Fabien requested review of this revision.Jan 28 2022, 10:36
This revision is now accepted and ready to land.Jan 28 2022, 10:38
This revision was landed with ongoing or failed builds.Jan 28 2022, 10:44
This revision was automatically updated to reflect the committed changes.