test: remove assert_blockchain_height
ClosedPublic
Actions

Authored by PiRK on Feb 1 2022, 13:43.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC23e2e06722fa: test: remove assert_blockchain_height

Summary

This simplifies the code and solves intermittent timeouts caused by commit rABC0c0123b0aa87

Note: I have not yet seen an intermittent timeout happen, but the conditions for this to happen exist after D10896

This is a backport of core#21117

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr20954

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18095
Build 36012: Build Diff	build-without-wallet · build-clang · build-debug · build-clang-tidy · build-diff
Build 36011: arc lint + arc unit

Event Timeline

PiRK created this revision.Feb 1 2022, 13:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 1 2022, 13:43

PiRK requested review of this revision.Feb 1 2022, 13:43

teamcity edited the summary of this revision. (Show Details)Feb 1 2022, 13:43

Harbormaster completed remote builds in B18095: Diff 32107.Feb 1 2022, 13:57

Fabien accepted this revision.Feb 1 2022, 14:40

This revision is now accepted and ready to land.Feb 1 2022, 14:40

Closed by commit rABC23e2e06722fa: test: remove assert_blockchain_height (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyFeb 1 2022, 14:51

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC23e2e06722fa: test: remove assert_blockchain_height.

Revision Contents
Changeset List

Path

Size

test/

functional/

feature_assumevalid.py

26 lines

Diff 32107

View Options

test/functional/feature_assumevalid.py

test: remove assert_blockchain_heightClosedPublicActions