Page MenuHomePhabricator
Differential D10999

include cmath in util_tests
ClosedPublic
Actions

Authored by PiRK on Feb 4 2022, 20:40.

Details

Reviewers
tyler-smith
Group Reviewers
Restricted Project
Commits
rABC77697f72d2a7: include cmath in util_tests
Summary

A missing include causes some builds to fail. It seems like cmath was previously imported indirectly via boost/thread/thread.hpp (removed from setup_common.h in D10992)

Test Plan

ninja all check-all

@bot build-linux64

Diff Detail

Event Timeline

PiRK created this revision.Feb 4 2022, 20:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 4 2022, 20:40
PiRK requested review of this revision.Feb 4 2022, 20:40
PiRK added a comment.Feb 4 2022, 20:41

@bot build-linux64 build-linux32 build-linux-aarch64 build-win64

teamcity awarded a token.Feb 4 2022, 20:42
Harbormaster completed remote builds in B18171: Diff 32229.Feb 4 2022, 20:54
tyler-smith accepted this revision.Feb 4 2022, 22:16
tyler-smith added a subscriber: tyler-smith.

Verified the removal of the transitive include and that the new one fixes the issue with building.

This revision is now accepted and ready to land.Feb 4 2022, 22:16
Closed by commit rABC77697f72d2a7: include cmath in util_tests (authored by PiRK). · Explain WhyFeb 5 2022, 08:34
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC77697f72d2a7: include cmath in util_tests.
PiRK mentioned this in D10993: net: compat.h related cleanup.Feb 7 2022, 08:27

Revision Contents
Changeset List

PathSize
src/
test/
1 line

Diff 32229

View Options

src/test/util_tests.cpp

Loading...