Move the add_outbounds helper to the test object in p2p_add_connections.py
ClosedPublic
Actions

Authored by Fabien on Feb 8 2022, 11:22.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABCc43edc8b5144: Move the add_outbounds helper to the test object in p2p_add_connections.py

Summary

This will make the next changes easier to review. There is no change in behavior.

Ref T1696.

Test Plan

./test/functional/test_runner.py p2p_add_connections

Diff Detail

Repository

rABC Bitcoin ABC

Branch

move_add_outbound_connections

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18191
Build 36190: Build Diff	build-clang · build-diff · build-clang-tidy · build-without-wallet · build-debug
Build 36189: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 8 2022, 11:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 8 2022, 11:22

Fabien requested review of this revision.Feb 8 2022, 11:22

Harbormaster completed remote builds in B18191: Diff 32261.Feb 8 2022, 11:37

Fabien added a child revision: D11010: [avalanche] Extend our outbound connections with avalanche enabled peers.Feb 8 2022, 11:51

PiRK accepted this revision.Feb 8 2022, 13:08

This revision is now accepted and ready to land.Feb 8 2022, 13:08

Closed by commit rABCc43edc8b5144: Move the add_outbounds helper to the test object in p2p_add_connections.py (authored by Fabien). · Explain WhyFeb 8 2022, 13:11

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCc43edc8b5144: Move the add_outbounds helper to the test object in p2p_add_connections.py.

Revision Contents
Changeset List

Path

Size

test/

functional/

p2p_add_connections.py

40 lines

Diff 32261

View Options

test/functional/p2p_add_connections.py

Move the add_outbounds helper to the test object in p2p_add_connections.pyClosedPublicActions