Page MenuHomePhabricator
Differential D11067

net: Make DNS lookup code testable
ClosedPublic
Actions

Authored by PiRK on Feb 17 2022, 17:18.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC83a625be647d: net: Make DNS lookup code testable
Summary

This is a partial backport of core#19415
https://github.com/bitcoin/bitcoin/pull/19415/commits/c6b4bfb4b3507f1a62290869d7435b0f54032104

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Feb 17 2022, 17:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 17 2022, 17:18
PiRK requested review of this revision.Feb 17 2022, 17:18
teamcity edited the summary of this revision. (Show Details)Feb 17 2022, 17:18
Harbormaster completed remote builds in B18295: Diff 32426.Feb 17 2022, 17:33
Fabien requested changes to this revision.Feb 17 2022, 18:40
Fabien added a subscriber: Fabien.

Wrong commit

This revision now requires changes to proceed.Feb 17 2022, 18:40
PiRK edited the summary of this revision. (Show Details)Feb 18 2022, 09:30

Fixed. I think I should stop submitting diffs at the end of the day.

PiRK requested review of this revision.Feb 18 2022, 09:31
PiRK added a child revision: D11069: net, doc: Doxygen updates and fixes in netbase.{h,cpp}.Feb 18 2022, 09:57
Fabien accepted this revision.Feb 18 2022, 17:31
This revision is now accepted and ready to land.Feb 18 2022, 17:31
Closed by commit rABC83a625be647d: net: Make DNS lookup code testable (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by PiRK). · Explain WhyFeb 21 2022, 13:20
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC83a625be647d: net: Make DNS lookup code testable.

Revision Contents
Changeset List

PathSize
src/
29 lines
131 lines

Diff 32457

View Options

src/netbase.h

Loading...
View Options

src/netbase.cpp

Loading...