Page MenuHomePhabricator
Differential D11094

Don't make "in" parameters look like "out"/"in-out" parameters: pass by ref to const instead of ref to non-const
ClosedPublic
Actions

Authored by PiRK on Feb 22 2022, 16:27.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCa95da7d32094: Don't make "in" parameters look like "out"/"in-out" parameters: pass by ref to…
Summary

This is a backport of core#20581

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Feb 22 2022, 16:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 22 2022, 16:27
PiRK requested review of this revision.Feb 22 2022, 16:27
teamcity edited the summary of this revision. (Show Details)Feb 22 2022, 16:27
PiRK added a comment.Feb 22 2022, 16:34

In validation.cpp::MemPoolAccept::PreChecks the Workspace is not actually const because of non-const aliases to its members.
See also this discussion about the const keyword not being appropriate in this case : https://github.com/bitcoin/bitcoin/pull/20581#pullrequestreview-570819930

Harbormaster completed remote builds in B18335: Diff 32485.Feb 22 2022, 16:41
Fabien accepted this revision.Feb 22 2022, 21:47
This revision is now accepted and ready to land.Feb 22 2022, 21:47
Closed by commit rABCa95da7d32094: Don't make "in" parameters look like "out"/"in-out" parameters: pass by ref to… (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by PiRK). · Explain WhyFeb 24 2022, 08:37
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCa95da7d32094: Don't make "in" parameters look like "out"/"in-out" parameters: pass by ref to….

Revision Contents
Changeset List

PathSize
src/
2 lines
2 lines
interfaces/
7 lines
node/
2 lines
rpc/
2 lines
2 lines
script/
2 lines
test/
2 lines
2 lines
2 lines
4 lines

Diff 32513

View Options

src/init.h

Loading...
View Options

src/init.cpp

Loading...
View Options

src/interfaces/wallet.cpp

Loading...
View Options

src/node/coinstats.cpp

Loading...
View Options

src/rpc/rawtransaction_util.h

Loading...
View Options

src/rpc/rawtransaction_util.cpp

Loading...
View Options

src/script/sigcache.cpp

Loading...
View Options

src/test/addrman_tests.cpp

Loading...
View Options

src/test/net_tests.cpp

Loading...
View Options

src/test/util_tests.cpp

Loading...
View Options

src/validation.cpp

Loading...