Differential D11100

Remove the ASERT anchor walk and caching
ClosedPublic
Actions

Authored by Fabien on Feb 23 2022, 07:31.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC5bf5a180447c: Remove the ASERT anchor walk and caching

Summary

After D11092 the axion activation (upgrade that enabled ASERT) is done from a block height. We can simply retrieve the anchor block from it's height without having to search for it based on time, and the cache is also no longer needed.

Test Plan

ninja all check-all

Run IBD with no assume valid.

./contrib/teamcity/build-configurations.py lint-circular-dependencies

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Feb 23 2022, 07:31

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 23 2022, 07:31

Fabien requested review of this revision.Feb 23 2022, 07:31

Harbormaster completed remote builds in B18347: Diff 32501.Feb 23 2022, 07:32

Build Bitcoin ABC Diffs / Diff Testing (lint-circular-dependencies) failed.

Tail of the build log:

/work /work/abc-ci-builds/lint-circular-dependencies
Good job! The circular dependency "pow/aserti32d -> validation -> pow/aserti32d" is no longer present.
Please remove it from EXPECTED_CIRCULAR_DEPENDENCIES in /work/test/lint/lint-circular-dependencies.sh
to make sure this circular dependency is not accidentally reintroduced.

Good job! The circular dependency "pow/aserti32d -> validation -> pow/pow -> pow/aserti32d" is no longer present.
Please remove it from EXPECTED_CIRCULAR_DEPENDENCIES in /work/test/lint/lint-circular-dependencies.sh
to make sure this circular dependency is not accidentally reintroduced.

/work/abc-ci-builds/lint-circular-dependencies
Build lint-circular-dependencies failed with exit code 1

Update to update the removed the circular dependencies

Fabien edited the test plan for this revision. (Show Details)Feb 23 2022, 07:36

Harbormaster completed remote builds in B18348: Diff 32504.Feb 23 2022, 08:08

PiRK accepted this revision.Feb 24 2022, 08:06

This revision is now accepted and ready to land.Feb 24 2022, 08:06

Closed by commit rABC5bf5a180447c: Remove the ASERT anchor walk and caching (authored by Fabien). · Explain WhyFeb 25 2022, 10:59

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC5bf5a180447c: Remove the ASERT anchor walk and caching.