Page MenuHomePhabricator
Differential D11092

Replace Axion activation time with the actual block height
ClosedPublic
Actions

Authored by Fabien on Feb 22 2022, 14:33.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCa314a4982c0b: Replace Axion activation time with the actual block height
Summary

The axion upgrade activated long time ago already, cleanup is long overdue.

This diff changes the activation from MTP based to height based, remove the -axionactivationtime option and updates the tests accordingly. Since we don't need to test for activation anymore, the regtest activation height is set to 0.

Depends on D11080.

Test Plan
ninja all check-all

Run IBD with no assume valid.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Feb 22 2022, 14:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 22 2022, 14:33
Fabien requested review of this revision.Feb 22 2022, 14:33
Fabien added a comment.Feb 22 2022, 14:34

@bot build-ibd-no-assumevalid-checkpoint

teamcity awarded a token.Feb 22 2022, 14:35
teamcity updated a token.Feb 22 2022, 14:40
Harbormaster completed remote builds in B18333: Diff 32482.Feb 22 2022, 14:46
PiRK accepted this revision.Feb 22 2022, 15:44
This revision is now accepted and ready to land.Feb 22 2022, 15:44
Fabien mentioned this in D11100: Remove the ASERT anchor walk and caching.Feb 23 2022, 07:31
Closed by commit rABCa314a4982c0b: Replace Axion activation time with the actual block height (authored by Fabien). · Explain WhyFeb 25 2022, 10:58
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCa314a4982c0b: Replace Axion activation time with the actual block height.
Fabien mentioned this in rABC5bf5a180447c: Remove the ASERT anchor walk and caching.
sdulfari mentioned this in D12970: Cleanup unused nodes in abc_mining_basic.py.Jan 10 2023, 21:05
sdulfari mentioned this in rABCb071759ef844: Cleanup unused nodes in abc_mining_basic.py.Jan 11 2023, 16:41

Revision Contents
Changeset List

PathSize
src/
6 lines
consensus/
7 lines
4 lines
2 lines
pow/
test/
37 lines
test/
25 lines
test/
functional/
60 lines
59 lines
lint/
2 lines

Diff 32532

View Options

src/chainparams.cpp

Loading...
View Options

src/consensus/activation.cpp

Loading...
View Options

src/consensus/params.h

Loading...
View Options

src/init.cpp

Loading...
View Options

src/pow/test/aserti32d_tests.cpp

Loading...
View Options

src/test/activation_tests.cpp

Loading...
View Options

test/functional/abc_feature_minerfund.py

Loading...
View Options

test/functional/abc_mining_basic.py

Loading...
View Options

test/lint/check-doc.py

Loading...