Page MenuHomePhabricator

[Linter] Update some PHP files to simplify the phpcs rules
ClosedPublic

Authored by Fabien on Feb 24 2022, 10:44.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCf3a23bf613de: [Linter] Update some PHP files to simplify the phpcs rules
Summary

A couple naming convention rules are enabled by default and added to php codesniffer 3.6. So far we disabled these rule but this causes previous phpcs versions to fail reading the rule file, because they don't know that rule. This diff implement these rules which are not harmful, simplifying the rule set and making it easier to install/run the linter with no issue.

Test Plan

With phpcs < 3.6 and >= 3.6:

arc lint --everything

Diff Detail

Repository
rABC Bitcoin ABC
Branch
phpcs_abstract_prefix
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18355
Build 36515: Build Diff
Build 36514: arc lint + arc unit