Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABCWEBd53bb374148e: [WEBSITE] Add download links for Electrum ABC releases

Summary

The code is adapted from the Bitcoin ABC releases page, with some simplifications (no release notes included, no #version anchors).
For the Windows relase, I only link to the ...-setup.exe file, as the other 2 options confuse most users.

The 4.3.x versions, which are not using eCash and XEC, are excluded from the list.

Test Plan

./scripts/fetch_electrum_releases.sh
bundle exec jekyll serve
firefox http://127.0.0.1:4000/electrum

Diff Detail

Repository

rABCWEB Bitcoin ABC Website

Branch

electrum_release

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 18377
Build 36554: arc lint + arc unit

Event Timeline

PiRK created this revision.Feb 28 2022, 09:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 28 2022, 09:46

PiRK requested review of this revision.Feb 28 2022, 09:46

Harbormaster completed remote builds in B18373: Diff 32544.Feb 28 2022, 09:46

Screenshot from 2022-02-28 10-31-54.png (1×1 px, 192 KB)

PiRK added a task: Restricted Maniphest Task.Feb 28 2022, 09:48

Is there any reason to propose the oldest versions on the page ? The node has it because all the versions from the same minor number are expected to work between upgrades and some businesses might need to accommodate the RPC changes, but what's the rationale for Electrum ABC ?

I would always recommend a new user to install the latest version, except in very rare situations (maybe for users with very old OS whose support has been dropped in a latest version).

The positive thing about showing older versions is just to give users a feel of how much they are behind the latest version.

I don't have a very strong opinion on the subject. While I was testing I considered reducing the number of displayed releases to 5. But all releases still work, so I decided to show them all.

Fabien requested changes to this revision.Mar 1 2022, 07:56

Fabien added inline comments.

scripts/fetch_documentation.sh
34 ↗	(On Diff #32544)	I don't see any reason why this belongs to this script, as it does no participate in fetching the documentation. You should extract it to its own script.