Page MenuHomePhabricator

[avalanche] Let the avalanche functional tests run both with and without the legacy proof format
ClosedPublic

Authored by Fabien on Mar 2 2022, 13:47.

Details

Summary

This diff prepares for converting the relevant functional tests to use either the legacy proof format (current node default) or the new format. It adds a facility for deserializing a proof from hex which will work with both formats, add a wrapper to the buildavalancheproof RPC, and adds a parameter to run a test with both formats.

For now only the abc_p2p_avalanche_peer_discovery.py is converted to demonstrate the feature. The other tests passing demonstrate that there is no change in behavior by default.

Test Plan
ninja check-functional-extended

./test/functional/test_runner.py --nocleanup abc_p2p_avalanche_peer_discovery

Check in the head of the debug logs that there is one test with legecyavaproof enabled and one disabled.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_proof_from_hex
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18389
Build 36575: Build Diffbuild-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 36574: arc lint + arc unit