[Cashtab] Correct proptypes validation for settings
ClosedPublic
Actions

Authored by bytesofman on Mar 3 2022, 00:58.

Details

Reviewers

kieran709

Group Reviewers

Restricted Project

Commits

rABC2733eb6c7f28: [Cashtab] Correct proptypes validation for settings

Summary

T2281

This prop is initialized as false as part of loading the parameter and validating it. This diff adjusts the proptypes validation to accept bool as well as object

Test Plan

npm start from master and see react proptype error in dev console.
npm start from this branch and see react proptype error is gone

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix-cashtabsettings-prop-error

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18394
Build 36585: Build Diff	cashtab-tests
Build 36584: arc lint + arc unit

Event Timeline

bytesofman created this revision.Mar 3 2022, 00:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 3 2022, 00:58

bytesofman requested review of this revision.Mar 3 2022, 00:58

Harbormaster completed remote builds in B18394: Diff 32577.Mar 3 2022, 01:01

kieran709 accepted this revision.Mar 8 2022, 15:15

This revision is now accepted and ready to land.Mar 8 2022, 15:15

Closed by commit rABC2733eb6c7f28: [Cashtab] Correct proptypes validation for settings (authored by bytesofman). · Explain WhyMar 8 2022, 17:36

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC2733eb6c7f28: [Cashtab] Correct proptypes validation for settings.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

components/

Common/

BalanceHeaderFiat.js

2 lines

Diff 32577

View Options

web/cashtab/src/components/Common/BalanceHeaderFiat.js

[Cashtab] Correct proptypes validation for settingsClosedPublicActions