Paths

Table of Contentst

Differential D11140

refactor: replace (sizeof(a)/sizeof(a[0])) with C++17 std::size
ClosedPublic
Actions

Authored by PiRK on Mar 7 2022, 15:04.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCb3c20cc418e7: refactor: replace (sizeof(a)/sizeof(a[0])) with C++17 std::size

Summary

refactor: iterate arrays via C++11 range-based for loops if idx is not needed

refactor: init vectors via std::{begin,end} to avoid pointer arithmetic

refactor: replace sizeof(a)/sizeof(a[0]) by std::size (C++17)

Removes the macro ARRAYLEN and also substitutes all other uses of the same
"sizeof(a)/sizeof(a[0])" pattern by std::size, available since C++17.

This is a backport of core#20429 and one commit from core#20245
https://github.com/bitcoin/bitcoin/pull/20245/commits/fa3967efdb07f1d22372f4ee2e602ea1fad04a57

The commit from core#20245 is doing the same thing as core#20249, and is unrelated to the rest of its PR, so the partial backport will not cause any issue.

Test Plan

ninja all check-all bitcoin-bench

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Mar 7 2022, 15:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 7 2022, 15:04

PiRK requested review of this revision.Mar 7 2022, 15:04

teamcity edited the summary of this revision. (Show Details)Mar 7 2022, 15:05

teamcity edited the summary of this revision. (Show Details)Mar 7 2022, 15:10

Harbormaster completed remote builds in B18423: Diff 32622.Mar 7 2022, 15:21

PiRK edited the summary of this revision. (Show Details)Mar 8 2022, 13:15

Fabien accepted this revision.Mar 10 2022, 08:39

This revision is now accepted and ready to land.Mar 10 2022, 08:39

Closed by commit rABCb3c20cc418e7: refactor: replace (sizeof(a)/sizeof(a[0])) with C++17 std::size (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>, committed by PiRK). · Explain WhyMar 10 2022, 09:03

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCb3c20cc418e7: refactor: replace (sizeof(a)/sizeof(a[0])) with C++17 std::size.

Revision Contents
Changeset List

Path

Size

src/

2 lines

bench/

5 lines

chainparams.cpp

9 lines

5 lines

qt/

networkstyle.cpp

14 lines

platformstyle.cpp

13 lines

4 lines

17 lines

rpc/

4 lines

4 lines

test/

base32_tests.cpp

2 lines

base64_tests.cpp

2 lines

4 lines

miner_tests.cpp

10 lines

script_tests.cpp

12 lines

scriptnum_tests.cpp

8 lines

sighash_tests.cpp

2 lines

util/

2 lines

Diff 32648

src/base58.cpp

Loading...

src/bench/data.cpp

Loading...

src/chainparams.cpp

Loading...

src/protocol.cpp

Loading...

src/qt/networkstyle.cpp

Loading...

src/qt/platformstyle.cpp

Loading...

src/random.cpp

Loading...

src/rest.cpp

Loading...

src/rpc/abc.cpp

Loading...

src/rpc/avalanche.cpp

Loading...

src/test/base32_tests.cpp

Loading...

src/test/base64_tests.cpp

Loading...

src/test/hash_tests.cpp

Loading...

src/test/miner_tests.cpp

Loading...

src/test/script_tests.cpp

Loading...

src/test/scriptnum_tests.cpp

Loading...

src/test/sighash_tests.cpp

Loading...

src/util/strencodings.h

Loading...