Differential D11144

[Cashtab] Fix fee calculation for one to many txs
ClosedPublic
Actions

Authored by bytesofman on Mar 7 2022, 18:22.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC812861103b5a: [Cashtab] Fix fee calculation for one to many txs

Summary

T2268

Fee calculation is based on 2 outputs. However, for multi-send txs, fees need to take into account the total number of outputs.

Test Plan

Generate a multi-send tx with 20+ outputs. Send successfully with no fee error.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

multisend-fee-calc-fix

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18430
Build 36657: Build Diff	cashtab-tests
Build 36656: arc lint + arc unit

Event Timeline

bytesofman created this revision.Mar 7 2022, 18:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 7 2022, 18:23

bytesofman requested review of this revision.Mar 7 2022, 18:23

Harbormaster completed remote builds in B18430: Diff 32631.Mar 7 2022, 18:26

Tested all ok https://explorer.bitcoinabc.org/tx/1c0c992e5f7355cbe6833f3fdd8945307f12782524e4d94d92164bc3a764eb93

This revision is now accepted and ready to land.Mar 8 2022, 11:14

Closed by commit rABC812861103b5a: [Cashtab] Fix fee calculation for one to many txs (authored by bytesofman). · Explain WhyMar 8 2022, 17:02

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC812861103b5a: [Cashtab] Fix fee calculation for one to many txs.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

hooks/

useBCH.js

7 lines

Diff 32631

View Options

web/cashtab/src/hooks/useBCH.js

[Cashtab] Fix fee calculation for one to many txsClosedPublicActions