Page MenuHomePhabricator
Differential D11152

[Cashtab] Webpack upgrade part 3, polyfill support
ClosedPublic
Actions

Authored by bytesofman on Mar 9 2022, 19:19.

Details

Reviewers
kieran709
Group Reviewers
Restricted Project
Commits
rABC93147d99ed25: [Cashtab] Webpack upgrade part 3, polyfill support
Summary

T1682

This diff implements step 3 outlined in the task description. These polyfill fixes are necessary for bchjs functions used in Cashtab, as the most recent version of create react app does not support polyfills by default.

Test Plan

cd web/cashtab-v2
npm i
npm start and observe default react app
npm run build and build success

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cashtab-webpack-upgrade-p3
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18441
Build 36679: Build Diff
Build 36678: arc lint + arc unit

Event Timeline

bytesofman created this revision.Mar 9 2022, 19:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 9 2022, 19:19
bytesofman requested review of this revision.Mar 9 2022, 19:19
Harbormaster completed remote builds in B18441: Diff 32646.Mar 9 2022, 19:19
bytesofman added a comment.Mar 9 2022, 19:21

Note, the 'use strict' was removed per eslint

kieran709 requested changes to this revision.Mar 16 2022, 15:11

Change test plan to include npm install.

This revision now requires changes to proceed.Mar 16 2022, 15:11
bytesofman requested review of this revision.Mar 16 2022, 17:51
bytesofman edited the test plan for this revision. (Show Details)
kieran709 accepted this revision.Mar 16 2022, 18:06
This revision is now accepted and ready to land.Mar 16 2022, 18:06
Closed by commit rABC93147d99ed25: [Cashtab] Webpack upgrade part 3, polyfill support (authored by bytesofman). · Explain WhyMar 16 2022, 18:29
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC93147d99ed25: [Cashtab] Webpack upgrade part 3, polyfill support.

Revision Contents
Changeset List

PathSize
web/
cashtab-v2/
config/
12 lines
850 lines
3 lines

Diff 32646

View Options

web/cashtab-v2/config/webpack.config.js

Loading...
View Options

web/cashtab-v2/package-lock.json

Loading...
View Options

web/cashtab-v2/package.json

Loading...