refactor: Separate hash and stats calculation in coinstats
ClosedPublic
Actions

Authored by PiRK on Mar 11 2022, 09:20.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCe3aff75e2fcb: refactor: Separate hash and stats calculation in coinstats

Summary

This is a backport of core#19145 [2/3]
https://github.com/bitcoin/bitcoin/pull/19145/commits/2474645f3b15687e7f196b89eb935d6e6a98a9da

Depends on D11155

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Mar 11 2022, 09:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 11 2022, 09:20

PiRK requested review of this revision.Mar 11 2022, 09:20

teamcity edited the summary of this revision. (Show Details)Mar 11 2022, 09:20

Harbormaster completed remote builds in B18452: Diff 32660.Mar 11 2022, 09:50

wrong commit

This revision now requires changes to proceed.Mar 11 2022, 11:08

fixed commit in description

Fabien accepted this revision.Mar 11 2022, 13:53

Fabien added inline comments.

src/node/coinstats.cpp
27 ↗	(On Diff #32660)	same comment as D11157, we should make it a function, but it's out of scope for this diff

This revision is now accepted and ready to land.Mar 11 2022, 13:53

PiRK added a child revision: D11162: make ApplyHash and ApplyStats take a TxId.Mar 11 2022, 17:00

Closed by commit rABCe3aff75e2fcb: refactor: Separate hash and stats calculation in coinstats (authored by Fabian Jahr <fjahr@protonmail.com>, committed by PiRK). · Explain WhyMar 14 2022, 07:47

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCe3aff75e2fcb: refactor: Separate hash and stats calculation in coinstats.

Revision Contents
Changeset List

Path

Size

src/

node/

coinstats.cpp

46 lines

Diff 32695

View Options

refactor: Separate hash and stats calculation in coinstatsClosedPublicActions