Page MenuHomePhabricator

[avalanche] Fix potential abc_rpc_getavalancheinfo test failure on slow machines
ClosedPublic

Authored by Fabien on Mar 12 2022, 08:07.

Details

Summary

The proof validation is done at each block and the test assumes that the validation occurs immediately after the node mined a block, but this assumption might be wrong on slow machines and the test has been seen failing when run with qemu. We can just wait for the output to turn right instead of asserting it immediately.

Test Plan

On a slow machine:

./test/functional/test_runner.py abc_rpc_getavalancheinfo

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_fix_getavalancheinfo_slow_machines
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18466
Build 36727: Build Diffbuild-diff · build-without-wallet · build-debug · build-clang-tidy · build-clang
Build 36726: arc lint + arc unit