Paths

Table of Contentst

Differential D11206

validation: Remove global ::LoadGenesisBlock
ClosedPublic
Actions

Authored by PiRK on Mar 17 2022, 09:28.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC2e4442d716e6: validation: Remove global ::LoadGenesisBlock

Summary

This is a backport of core#21055 [2/16] and core#21270 [1/12]
https://github.com/bitcoin/bitcoin/pull/21055/commits/4927c9e6991b09a36a41aab93a0e05332d899611
https://github.com/bitcoin/bitcoin/pull/21270/commits/a04aac493fd564894166d58ed4cdfd9ad4f561cb

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18539
Build 36873: Build Diff	build-without-wallet · build-diff · build-clang-tidy · lint-circular-dependencies · build-clang · build-debug
Build 36872: arc lint + arc unit

Event Timeline

PiRK created this revision.Mar 17 2022, 09:28

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 17 2022, 09:28

PiRK requested review of this revision.Mar 17 2022, 09:28

teamcity edited the summary of this revision. (Show Details)Mar 17 2022, 09:28

PiRK added a child revision: D11207: validation: Remove global ::PreciousBlock,ResetBlockFailureFlags.Mar 17 2022, 09:29

Harbormaster completed remote builds in B18539: Diff 32789.Mar 17 2022, 09:41

Fabien accepted this revision.Mar 17 2022, 10:27

This revision is now accepted and ready to land.Mar 17 2022, 10:27

Closed by commit rABC2e4442d716e6: validation: Remove global ::LoadGenesisBlock (authored by Carl Dong <contact@carldong.me>, committed by PiRK). · Explain WhyMar 17 2022, 11:10

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC2e4442d716e6: validation: Remove global ::LoadGenesisBlock.

Revision Contents
Changeset List

Path

Size

src/

init.cpp

5 lines

test/

util/

setup_common.cpp

2 lines

validation.h

11 lines

validation.cpp

4 lines

Diff 32789

View Options

src/init.cpp

View Options

src/test/util/setup_common.cpp

View Options

src/validation.h

View Options

validation: Remove global ::LoadGenesisBlockClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 32789

src/init.cpp

src/test/util/setup_common.cpp

src/validation.h

src/validation.cpp

validation: Remove global ::LoadGenesisBlock
ClosedPublic
Actions

Revision Contents
Changeset List