Page MenuHomePhabricator

Make ZMQ client python example asynchronous
ClosedPublic

Authored by aethn on Feb 23 2018, 04:54.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Restricted Owners Package(Owns No Changed Paths)
Commits
rSTAGINGfe952a5e5417: Make ZMQ client python example asynchronous
rABCfe952a5e5417: Make ZMQ client python example asynchronous
Summary

Most of the code is from Bitcoin Core's implementation; however this was broken for versions of ZMQ newer than 15. Fixed this, removed hardcoded ip address, and switched to f-strings.

Moves old zmq_sub into zmq_sub27

Test Plan

Run the client code and compare the resulting data to the respective bitcoin-cli data. Note that transactions are given from the mempool and not blocks.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
D1120
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1926
Build 2010: Bitcoin ABC Buildbot (legacy)
Build 2009: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Feb 23 2018, 04:54

Hi aethn,

Thanks for making it over here!

I see that you mention "Removes build instructions for Boost and redirects users to the official Boost documentation" in the commit message. Could you please separate that out into another commit and resubmit this? We keep diffs limited to one purpose at a time whenever possible.

Did you submit this through the web UI, or are you working through arc?

Also, I looked around -- I'm not sure what the purpose of this script is for. Is it just sample code for how to interact with bitcoind using zmq? If so, would you be able to put a README.md in the same folder and call that out?

schancel requested changes to this revision.Feb 24 2018, 03:11
This revision now requires changes to proceed.Feb 24 2018, 03:11

Hey schancel,

I used arc but do you think it's necessary to add a Readme when the ReadMe on ZMQ already explains the purpose of this file?

Separates commits

aethn retitled this revision from Summary: to Fixes and makes ZMQ implementation asynchronous.Feb 24 2018, 21:20
aethn edited the summary of this revision. (Show Details)
aethn edited the test plan for this revision. (Show Details)
aethn retitled this revision from Fixes and makes ZMQ implementation asynchronous to Fixes and makes ZMQ client example asynchronous.
schancel retitled this revision from Fixes and makes ZMQ client example asynchronous to Make ZMQ client python example asynchronous.Feb 24 2018, 21:22
This revision is now accepted and ready to land.Feb 28 2018, 06:18
This revision was automatically updated to reflect the committed changes.