Paths

Table of Contentst

Differential D11223

miner: Pass in chainstate to BlockAssembler::CreateNewBlock
ClosedPublic
Actions

Authored by PiRK on Mar 18 2022, 09:45.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCd1b32162feaf: miner: Pass in chainstate to BlockAssembler::CreateNewBlock

Summary

This is a backport of core#21270 [2, 3 & 4/9]
https://github.com/bitcoin/bitcoin/pull/21270/commits/d0de61b764fc7e9c670b69d8210705da296dd245
https://github.com/bitcoin/bitcoin/pull/21270/commits/46b7f29340acb399fbd2378508a204d8d8ee8fca
https://github.com/bitcoin/bitcoin/pull/21270/commits/2afcf24408b4453e4418ebfb326b141f6ea8647c

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr21055

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18561
Build 36917: Build Diff	build-without-wallet · build-clang-tidy · lint-circular-dependencies · build-clang · build-debug · build-diff
Build 36916: arc lint + arc unit

Event Timeline

PiRK created this revision.Mar 18 2022, 09:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 18 2022, 09:45

PiRK requested review of this revision.Mar 18 2022, 09:45

teamcity edited the summary of this revision. (Show Details)Mar 18 2022, 09:46

Harbormaster completed remote builds in B18561: Diff 32829.Mar 18 2022, 09:57

@bot build-fuzzer

teamcity awarded a token.Mar 18 2022, 10:09

Fabien accepted this revision.Mar 18 2022, 10:39

This revision is now accepted and ready to land.Mar 18 2022, 10:39

Closed by commit rABCd1b32162feaf: miner: Pass in chainstate to BlockAssembler::CreateNewBlock (authored by PiRK). · Explain WhyMar 21 2022, 08:50

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCd1b32162feaf: miner: Pass in chainstate to BlockAssembler::CreateNewBlock.

PiRK added a reverting change: D11504: Revert "miner: Pass in chainstate to BlockAssembler::CreateNewBlock".May 20 2022, 10:54

Revision Contents
Changeset List

Path

Size

src/

miner.h

2 lines

miner.cpp

11 lines

rpc/

mining.cpp

8 lines

test/

blockfilter_index_tests.cpp

3 lines

miner_tests.cpp

54 lines

util/

mining.cpp

8 lines

setup_common.cpp

5 lines

validation_block_tests.cpp

4 lines

Diff 32829

View Options

src/miner.h

View Options

src/miner.cpp

View Options

src/rpc/mining.cpp

View Options

src/test/blockfilter_index_tests.cpp

View Options

src/test/miner_tests.cpp

View Options

src/test/util/mining.cpp

View Options

src/test/util/setup_common.cpp

View Options

src/test/validation_block_tests.cpp

miner: Pass in chainstate to BlockAssembler::CreateNewBlockClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 32829

src/miner.h

src/miner.cpp

src/rpc/mining.cpp

src/test/blockfilter_index_tests.cpp

src/test/miner_tests.cpp

src/test/util/mining.cpp

src/test/util/setup_common.cpp

src/test/validation_block_tests.cpp

miner: Pass in chainstate to BlockAssembler::CreateNewBlock
ClosedPublic
Actions

Revision Contents
Changeset List