Page MenuHomePhabricator

[Cashtab] Ensure browserify is installed before extension build
ClosedPublic

Authored by bytesofman on Mar 18 2022, 19:55.

Details

Summary

T2322

For npm run extension to work properly, browserify must be installed globally. Currently, if the user runs npm run extension without browserify installed globally, some files will be corrupted.

This diff adds a preextension script, so that npm i -g browserify will always be run before npm run extension. This prevents a user from unintentionally building the extension without browserify installed.

Test Plan
npm uninstall -g browserify
npm run extension

Observe that browserify is installed before the extension script is run. Confirm by checking git status and noting that no files are changed.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
check-for-browserify
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18575
Build 36941: Build Diffcashtab-tests
Build 36940: arc lint + arc unit