Differential D11244

Fix the build on some platforms by using an explicit cast for Univalue type
ClosedPublic
Actions

Authored by Fabien on Mar 22 2022, 20:10.

Details

Reviewers

tyler-smith

Group Reviewers

Restricted Project

Commits

rABC779919230ef7: Fix the build on some platforms by using an explicit cast for Univalue type

Summary

It appears that std::vector::size_type is not implicitely convertible to uint64_t or int64_t on on platforms , so cast it explicitely.

Test Plan

./contrib/teamcity/build-configurations.py build-linux32
./contrib/teamcity/build-configurations.py build-native-osx

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_univalue_osx

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18605
Build 37001: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 37000: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 22 2022, 20:10

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 22 2022, 20:10

Fabien requested review of this revision.Mar 22 2022, 20:10

@bot build-linux32 build-native-osx

teamcity awarded a token.Mar 22 2022, 20:13

Harbormaster completed remote builds in B18605: Diff 32901.Mar 22 2022, 20:32

Change looks correct.

This revision is now accepted and ready to land.Mar 22 2022, 20:38

Closed by commit rABC779919230ef7: Fix the build on some platforms by using an explicit cast for Univalue type (authored by Fabien). · Explain WhyMar 22 2022, 20:39

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC779919230ef7: Fix the build on some platforms by using an explicit cast for Univalue type.

Revision Contents
Changeset List

Path

Size

src/

rpc/

avalanche.cpp

2 lines

Diff 32901

View Options

Fix the build on some platforms by using an explicit cast for Univalue typeClosedPublicActions