Page MenuHomePhabricator
Differential D11281

[Cashtab] Add disabled button component & use in Send.js
ClosedPublic
Actions

Authored by kieran709 on Mar 30 2022, 15:25.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC03f050eb1b6c: [Cashtab] Add disabled button component & use in Send.js
Summary

Related to task T2359. In a previous revision, the SecondaryButton styled component was changed to show the disabled symbol on hover, however since this button is used in different contexts throughout the app, this revision adds a disabled button component.

Test Plan

cd web/cashtab-v2 && npm start
in a private browser, hover over the import wallet button on the home screen
the cursor should be a pointer
in a non-private browser
navigate to the send screen
add invalid eCash address or invalid XEC amount
over over the send button
observe the disabled symbol on the send button.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
disabled-button-component
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18686
Build 37163: Build Diffcashtab-tests
Build 37162: arc lint + arc unit

Event Timeline

kieran709 created this revision.Mar 30 2022, 15:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 30 2022, 15:25
kieran709 requested review of this revision.Mar 30 2022, 15:25
Harbormaster completed remote builds in B18679: Diff 32997.Mar 30 2022, 15:28
bytesofman requested changes to this revision.Mar 30 2022, 17:26

We should land this once the pointer issue is fixed, to correct the current issue with Cashtab showing 'disabled' cursor on non-disabled buttons. Going forward, we should change the css of PrimaryButton or SecondaryButton based on the disabled prop, instead of switching out entirely different components.

I'll create a task for that.

web/cashtab/src/components/Common/PrimaryButton.js
41 ↗(On Diff #32997)

cursor: pointer

This revision now requires changes to proceed.Mar 30 2022, 17:26
kieran709 updated this revision to Diff 33004.Mar 30 2022, 17:44

responding to review feedback

Harbormaster completed remote builds in B18686: Diff 33004.Mar 30 2022, 17:47
bytesofman requested changes to this revision.Mar 30 2022, 17:53
bytesofman added inline comments.
web/cashtab/src/components/Common/PrimaryButton.js
41

cursor: cursor --> cursor: pointer

This revision now requires changes to proceed.Mar 30 2022, 17:53
kieran709 updated this revision to Diff 33010.Mar 30 2022, 19:46

respdonding to review feedback

Harbormaster completed remote builds in B18689: Diff 33010.Mar 30 2022, 19:50
teamcity added a comment.Mar 30 2022, 19:50
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests:  Without wallet defined ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Without wallet defined 1`

- Snapshot  - 1
+ Received  + 1

@@ -61,11 +61,11 @@
        </svg>
      </span>
       New Wallet
    </button>
    <button
-     className="sc-cSHVUG bFbFlg"
+     className="sc-cSHVUG kUJUGX"
      onClick={[Function]}
    >
      <span
        aria-label="import"
        className="anticon anticon-import"
    at Object.<anonymous> (/work/web/cashtab/src/components/Receive/__tests__/Receive.test.js:107:18)
    at Promise.then.completed (/work/web/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/web/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
    at _runTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/web/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/web/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/web/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)Error: expect(received).toMatchSnapshot()

Snapshot name: `Without wallet defined 1`

- Snapshot  - 1
+ Received  + 1

@@ -61,11 +61,11 @@
        </svg>
      </span>
       New Wallet
    </button>
    <button
-     className="sc-cSHVUG bFbFlg"
+     className="sc-cSHVUG kUJUGX"
      onClick={[Function]}
    >
      <span
        aria-label="import"
        className="anticon anticon-import"
    at Object.<anonymous> (/work/web/cashtab/src/components/Home/__tests__/Home.test.js:88:18)
    at Promise.then.completed (/work/web/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/web/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
    at _runTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/web/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/web/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/web/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)
====== CashTab Unit Tests:  Configure without a wallet ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Configure without a wallet 1`

- Snapshot  - 1
+ Received  + 1

@@ -120,11 +120,11 @@
          </svg>
        </span>
         New Wallet
      </button>
      <button
-       className="sc-cvbbAY caTSwS"
+       className="sc-cvbbAY eOLbDk"
        onClick={[Function]}
      >
        <span
          aria-label="import"
          className="anticon anticon-import"
    at Object.<anonymous> (/work/web/cashtab/src/components/Configure/__tests__/Configure.test.js:17:18)
    at Promise.then.completed (/work/web/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/web/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
    at _runTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/web/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/web/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/web/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)
====== CashTab Unit Tests:  Configure with a wallet ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Configure with a wallet 1`

- Snapshot  - 1
+ Received  + 1

@@ -160,11 +160,11 @@
          </svg>
        </span>
         New Wallet
      </button>
      <button
-       className="sc-cvbbAY caTSwS"
+       className="sc-cvbbAY eOLbDk"
        onClick={[Function]}
      >
        <span
          aria-label="import"
          className="anticon anticon-import"
    at Object.<anonymous> (/work/web/cashtab/src/components/Configure/__tests__/Configure.test.js:31:18)
    at Promise.then.completed (/work/web/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/web/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
    at _runTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/web/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/web/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/web/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)

Each failure log is accessible here:
CashTab Unit Tests: Without wallet defined
CashTab Unit Tests: Configure without a wallet
CashTab Unit Tests: Configure with a wallet

kieran709 updated this revision to Diff 33011.Mar 30 2022, 19:57

updated snapshots

Harbormaster completed remote builds in B18690: Diff 33011.Mar 30 2022, 20:01
bytesofman accepted this revision.Mar 30 2022, 22:44
This revision is now accepted and ready to land.Mar 30 2022, 22:44
kieran709 updated this revision to Diff 33027.Mar 31 2022, 14:49

rebased to master

kieran709 updated this revision to Diff 33028.Mar 31 2022, 14:50

updated snapshots

Harbormaster completed remote builds in B18699: Diff 33027.Mar 31 2022, 14:52
teamcity added a comment.Mar 31 2022, 14:52
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests:  Wallet with BCH balances and tokens and state field ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet with BCH balances and tokens and state field 1`

- Snapshot  - 10
+ Received  +  2

@@ -26,15 +26,11 @@
              "width": "auto",
            }
          }
        >
          <div
- <<<<<<< HEAD
-           className="sc-jzJRlG kGXhCS"
- =======
-           className="sc-cSHVUG gfECsd"
- >>>>>>> d50a38d37 ([Cashtab] Add disabled button component & use in Send.js)
+           className="sc-cSHVUG iNTIbE"
          >
            <div
              className="ant-row ant-form-item ant-form-item-with-help"
              style={Object {}}
            >
@@ -143,15 +139,11 @@
                </div>
              </div>
            </div>
          </div>
          <div
- <<<<<<< HEAD
-           className="sc-jzJRlG kGXhCS"
- =======
-           className="sc-cSHVUG gfECsd"
- >>>>>>> d50a38d37 ([Cashtab] Add disabled button component & use in Send.js)
+           className="sc-cSHVUG iNTIbE"
          >
            <div
              className="ant-row ant-form-item ant-form-item-with-help"
              style={Object {}}
            >
    at Object.<anonymous> (/work/web/cashtab/src/components/Send/__tests__/SendToken.test.js:71:18)
    at Promise.then.completed (/work/web/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/web/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
    at _runTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/web/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/web/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/web/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)
====== CashTab Unit Tests:  Configure without a wallet ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Configure without a wallet 1`

- Snapshot  - 1
+ Received  + 1

@@ -1,10 +1,10 @@
  <div
    className="sc-gqjmRU dYraLr"
  >
    <div
-     className="sc-gipzik MdceN"
+     className="sc-gipzik kiYvZB"
    >
      <h2>
        <span
          aria-label="copy"
          className="anticon anticon-copy sc-bdVaJa jyutTw"
    at Object.<anonymous> (/work/web/cashtab/src/components/Configure/__tests__/Configure.test.js:17:18)
    at Promise.then.completed (/work/web/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/web/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
    at _runTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/web/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/web/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/web/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)
====== CashTab Unit Tests:  Configure with a wallet ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Configure with a wallet 1`

- Snapshot  - 1
+ Received  + 1

@@ -1,10 +1,10 @@
  <div
    className="sc-gqjmRU dYraLr"
  >
    <div
-     className="sc-gipzik MdceN"
+     className="sc-gipzik kiYvZB"
    >
      <h2>
        <span
          aria-label="copy"
          className="anticon anticon-copy sc-bdVaJa jyutTw"
    at Object.<anonymous> (/work/web/cashtab/src/components/Configure/__tests__/Configure.test.js:31:18)
    at Promise.then.completed (/work/web/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/web/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
    at _runTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/web/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/web/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/web/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)

Each failure log is accessible here:
CashTab Unit Tests: Wallet with BCH balances and tokens and state field
CashTab Unit Tests: Configure without a wallet
CashTab Unit Tests: Configure with a wallet

Harbormaster completed remote builds in B18700: Diff 33028.Mar 31 2022, 14:53
kieran709 updated this revision to Diff 33030.Mar 31 2022, 17:17

test comment to force re-test

Harbormaster completed remote builds in B18701: Diff 33030.Mar 31 2022, 17:20
kieran709 updated this revision to Diff 33031.Mar 31 2022, 17:27

removed unnecessary test comment

Harbormaster completed remote builds in B18702: Diff 33031.Mar 31 2022, 17:30
bytesofman accepted this revision.Mar 31 2022, 21:03
Closed by commit rABC03f050eb1b6c: [Cashtab] Add disabled button component & use in Send.js (authored by kieran709). · Explain WhyApr 1 2022, 13:34
This revision was automatically updated to reflect the committed changes.
kieran709 added a commit: rABC03f050eb1b6c: [Cashtab] Add disabled button component & use in Send.js.

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
components/
Airdrop/
__tests__/
__snapshots__/
Common/
29 lines
Configure/
__tests__/
__snapshots__/
Home/
__tests__/
__snapshots__/
Receive/
__tests__/
__snapshots__/
Send/
4 lines
__tests__/
__snapshots__/
Tokens/
__tests__/
__snapshots__/

Diff 33004

View Options

web/cashtab/src/components/Airdrop/__tests__/__snapshots__/Airdrop.test.js.snap

Loading...
View Options

web/cashtab/src/components/Common/PrimaryButton.js

Loading...
View Options

web/cashtab/src/components/Configure/__tests__/__snapshots__/Configure.test.js.snap

Loading...
View Options

web/cashtab/src/components/Home/__tests__/__snapshots__/Home.test.js.snap

Loading...
View Options

web/cashtab/src/components/Receive/__tests__/__snapshots__/Receive.test.js.snap

Loading...
View Options

web/cashtab/src/components/Send/Send.js

Loading...
View Options

web/cashtab/src/components/Send/__tests__/__snapshots__/Send.test.js.snap

Loading...
View Options

web/cashtab/src/components/Send/__tests__/__snapshots__/SendToken.test.js.snap

Loading...
View Options

web/cashtab/src/components/Tokens/__tests__/__snapshots__/CreateTokenForm.test.js.snap

Loading...
View Options

web/cashtab/src/components/Tokens/__tests__/__snapshots__/Tokens.test.js.snap

Loading...