Page MenuHomePhabricator
Differential D11286

[Cashtab] CSS patch font color of alerts in Configure.js
ClosedPublic
Actions

Authored by kieran709 on Mar 30 2022, 17:24.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC9af26db728e2: [Cashtab] CSS patch font color of alerts in Configure.js
Summary

Related to task T2341. Font color of Seed Phrase and translation alerts in Configure.js changed to black during the webpack upgrade, however the previous color is not part of the existing theme so it has been hardcoded in.

Test Plan

cd web/cashtab-v2
npm start
navigate to the Configure tab
observe that the alerts at the top of the page have the correct font color.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
settings-tab-alerts-css-patch
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18684
Build 37159: Build Diffcashtab-tests
Build 37158: arc lint + arc unit

Event Timeline

kieran709 created this revision.Mar 30 2022, 17:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 30 2022, 17:24
kieran709 requested review of this revision.Mar 30 2022, 17:24
Harbormaster completed remote builds in B18684: Diff 33002.Mar 30 2022, 17:27
bytesofman requested changes to this revision.Mar 30 2022, 17:39
bytesofman added inline comments.
web/cashtab/src/components/Configure/Configure.js
226

All color variables should be pulled from theme. If this color isn't there, it's okay to add it.

This revision now requires changes to proceed.Mar 30 2022, 17:39
kieran709 updated this revision to Diff 33008.Mar 30 2022, 18:55

Responding to review feedback

bytesofman accepted this revision.Mar 30 2022, 18:58
This revision is now accepted and ready to land.Mar 30 2022, 18:58
Harbormaster completed remote builds in B18688: Diff 33008.Mar 30 2022, 19:01
Closed by commit rABC9af26db728e2: [Cashtab] CSS patch font color of alerts in Configure.js (authored by kieran709). · Explain WhyMar 31 2022, 14:30
This revision was automatically updated to reflect the committed changes.
kieran709 added a commit: rABC9af26db728e2: [Cashtab] CSS patch font color of alerts in Configure.js.

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
components/
Configure/
4 lines
__tests__/
__snapshots__/

Diff 33002

View Options

web/cashtab/src/components/Configure/Configure.js

Loading...
View Options

web/cashtab/src/components/Configure/__tests__/__snapshots__/Configure.test.js.snap

Loading...