Page MenuHomePhabricator
Differential D11289

[Cashab] Corrected proptype in QRCode
ClosedPublic
Actions

Authored by kieran709 on Mar 31 2022, 18:16.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC5ee8030024f1: [Cashab] Corrected proptype in QRCode
Summary

Related to task T2367. In QRCode.js, the proptype for isCashAddress shoud be PropTypes.bool.

Test Plan

npm start
navigate go receive page
Observe that you do not see this error in dev console

image.png (358×591 px, 83 KB)

Diff Detail

Repository
rABC Bitcoin ABC
Branch
wrong-proptype-QRCode
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18703
Build 37197: Build Diffcashtab-tests
Build 37196: arc lint + arc unit

Event Timeline

kieran709 created this revision.Mar 31 2022, 18:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 31 2022, 18:17
kieran709 requested review of this revision.Mar 31 2022, 18:17
Harbormaster completed remote builds in B18703: Diff 33032.Mar 31 2022, 18:19
bytesofman accepted this revision.Mar 31 2022, 23:04

FYI test plan should be

npm start
navigate go receive page
Observe that you do not see this error in dev console

image.png (358×591 px, 83 KB)

This revision is now accepted and ready to land.Mar 31 2022, 23:04
kieran709 edited the test plan for this revision. (Show Details)Apr 1 2022, 14:05
Closed by commit rABC5ee8030024f1: [Cashab] Corrected proptype in QRCode (authored by kieran709). · Explain WhyApr 1 2022, 14:06
This revision was automatically updated to reflect the committed changes.
kieran709 added a commit: rABC5ee8030024f1: [Cashab] Corrected proptype in QRCode.

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
components/
Common/
2 lines

Diff 33032

View Options

web/cashtab/src/components/Common/QRCode.js

Loading...