Page MenuHomePhabricator

[Cashab] Corrected proptype in QRCode
ClosedPublic

Authored by kieran709 on Mar 31 2022, 18:16.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC5ee8030024f1: [Cashab] Corrected proptype in QRCode
Summary

Related to task T2367. In QRCode.js, the proptype for isCashAddress shoud be PropTypes.bool.

Test Plan

npm start
navigate go receive page
Observe that you do not see this error in dev console

image.png (358×591 px, 83 KB)

Diff Detail

Repository
rABC Bitcoin ABC
Branch
wrong-proptype-QRCode
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18703
Build 37197: Build Diffcashtab-tests
Build 37196: arc lint + arc unit

Event Timeline

FYI test plan should be

npm start
navigate go receive page
Observe that you do not see this error in dev console

image.png (358×591 px, 83 KB)

This revision is now accepted and ready to land.Mar 31 2022, 23:04
This revision was automatically updated to reflect the committed changes.