Differential D11293

[avalanche] Use constants for delays in abc_p2p_getavaaddr
ClosedPublic
Actions

Authored by Fabien on Apr 1 2022, 09:06.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCf87c5a6dd01c: [avalanche] Use constants for delays in abc_p2p_getavaaddr

Summary

The test uses a lot of mock times and it's getting difficult to know who is who, so use constants instead of magic number to make this more obvious. There is no change in behavior.

Depends on D11292.

Test Plan

./test/functional/test_runner.py abc_p2p_getavaaddr

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Apr 1 2022, 09:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 1 2022, 09:06

Fabien requested review of this revision.Apr 1 2022, 09:06

Harbormaster completed remote builds in B18709: Diff 33038.Apr 1 2022, 09:22

Fabien added a child revision: D11294: [avalanche] Reduce the getavaaddr message sending interval.Apr 1 2022, 10:08

PiRK accepted this revision.Apr 1 2022, 12:50

This revision is now accepted and ready to land.Apr 1 2022, 12:50

Closed by commit rABCf87c5a6dd01c: [avalanche] Use constants for delays in abc_p2p_getavaaddr (authored by Fabien). · Explain WhyApr 1 2022, 13:06

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCf87c5a6dd01c: [avalanche] Use constants for delays in abc_p2p_getavaaddr.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc_p2p_getavaaddr.py

29 lines

Diff 33041

View Options

test/functional/abc_p2p_getavaaddr.py

[avalanche] Use constants for delays in abc_p2p_getavaaddrClosedPublicActions