Differential D11303

doc: add explanations for assert in index and magic numbers in test
ClosedPublic
Actions

Authored by PiRK on Apr 5 2022, 09:20.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCf929502483ea: doc: add explanations for assert in index and magic numbers in test

Summary

These were suggested in review of #23365

Co-authored-by: John Newbery <john@johnnewbery.com>

This is a backport of core#23777

Depends on D11299

Test Plan

NA - comments only

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Apr 5 2022, 09:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 5 2022, 09:20

PiRK requested review of this revision.Apr 5 2022, 09:20

teamcity edited the summary of this revision. (Show Details)Apr 5 2022, 09:20

PiRK edited the summary of this revision. (Show Details)Apr 5 2022, 09:23

PiRK added a parent revision: D11299: Allow maintaining the blockfilterindex when using prune.

Harbormaster completed remote builds in B18726: Diff 33064.Apr 5 2022, 09:36

Fabien accepted this revision.Apr 5 2022, 09:51

This revision is now accepted and ready to land.Apr 5 2022, 09:51

rebase. Now this revision no longer touches the comment added in the previous commit, because it has been improved in D11299

Harbormaster completed remote builds in B18730: Diff 33068.Apr 5 2022, 10:14

Closed by commit rABCf929502483ea: doc: add explanations for assert in index and magic numbers in test (authored by Martin Zumsande <mzumsande@gmail.com>, committed by PiRK). · Explain WhyApr 5 2022, 12:44

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCf929502483ea: doc: add explanations for assert in index and magic numbers in test.

Revision Contents
Changeset List

Path

Size

src/

index/

base.cpp

3 lines

test/

functional/

feature_blockfilterindex_prune.py

3 lines

Diff 33073

View Options

src/index/base.cpp