Page MenuHomePhabricator
Differential D11313

[Cashtab] Copy OP_RETURN message button added to Tx collapse
ClosedPublic
Actions

Authored by kieran709 on Apr 5 2022, 21:12.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC5e166a573769: [Cashtab] Copy OP_RETURN message button added to Tx collapse
Summary

Related to task T2167. Added button to Tx dropdown to copy OP_RETURN message if one is present.

Test Plan

cd web/cashtab
npm start
if there are no Txs in TxHistory with an OP_RETURN msg, send one from another wallet
click a Tx with an OP_RETURN msg
click the Copy OP_RETURN button
observe the notification
ensure that the text copied to clipboard is correct

click a Tx with no OP_RETURN msg
observe that there is no Copy OP_RETURN button

Diff Detail

Repository
rABC Bitcoin ABC
Branch
copy-op-return-msg-button
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18742
Build 37275: Build Diffcashtab-tests
Build 37274: arc lint + arc unit

Event Timeline

kieran709 created this revision.Apr 5 2022, 21:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 5 2022, 21:12
kieran709 requested review of this revision.Apr 5 2022, 21:13
Harbormaster completed remote builds in B18742: Diff 33087.Apr 5 2022, 21:15
bytesofman requested changes to this revision.Apr 5 2022, 21:26

See inline comments -- users don't need to see the phrase OP_RETURN, it's for devs

web/cashtab/src/components/Home/Tx.js
684

Cashtab message copied to clipboard

690

Copy Msg

This revision now requires changes to proceed.Apr 5 2022, 21:26
kieran709 updated this revision to Diff 33090.Apr 5 2022, 22:14

responding to review feedback

Harbormaster completed remote builds in B18744: Diff 33090.Apr 5 2022, 22:16
bytesofman accepted this revision.Apr 6 2022, 00:01
This revision is now accepted and ready to land.Apr 6 2022, 00:01
Closed by commit rABC5e166a573769: [Cashtab] Copy OP_RETURN message button added to Tx collapse (authored by kieran709). · Explain WhyApr 6 2022, 12:38
This revision was automatically updated to reflect the committed changes.
kieran709 added a commit: rABC5e166a573769: [Cashtab] Copy OP_RETURN message button added to Tx collapse.

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
components/
Home/
22 lines

Diff 33087

View Options

web/cashtab/src/components/Home/Tx.js

Loading...