Page MenuHomePhabricator
Differential D11315

[Cashtab] Center collapse headers in Send.js
ClosedPublic
Actions

Authored by kieran709 on Apr 6 2022, 17:10.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC530a41fbf048: [Cashtab] Center collapse headers in Send.js
Summary

First step in task T2348. The headers of the three styled collapses in Send.js should be centered, with the arrow icon staying to the left of the collapse.

Test Plan

cd web/cashtab && npm start
navigate to the Send page
observe that in each of the 3 styled collapses, the header is centered

Diff Detail

Repository
rABC Bitcoin ABC
Branch
collapse-styling-sendjs-patch
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18750
Build 37291: Build Diffcashtab-tests
Build 37290: arc lint + arc unit

Event Timeline

kieran709 created this revision.Apr 6 2022, 17:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 6 2022, 17:10
kieran709 requested review of this revision.Apr 6 2022, 17:10
Harbormaster completed remote builds in B18750: Diff 33107.Apr 6 2022, 17:14
teamcity added a comment.Apr 6 2022, 17:14
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests:  Wallet without BCH balance ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet without BCH balance 1`

- Snapshot  - 3
+ Received  + 3

@@ -377,11 +377,11 @@
              >
                Send
              </button>
            </div>
            <div
-             className="sc-bRBYWo kDCtna"
+             className="sc-bRBYWo fNHvEm"
            >
              <div
                className="ant-collapse ant-collapse-icon-position-left sc-kAzzGY itTQAx"
                role={null}
                style={
@@ -433,11 +433,11 @@
            </div>
          </form>
        </div>
      </div>
      <div
-       className="sc-bRBYWo kDCtna"
+       className="sc-bRBYWo fNHvEm"
      >
        <div
          className="ant-collapse ant-collapse-icon-position-left sc-kAzzGY itTQAx"
          role={null}
          style={
@@ -486,11 +486,11 @@
            </div>
          </div>
        </div>
      </div>
      <div
-       className="sc-bRBYWo kDCtna"
+       className="sc-bRBYWo fNHvEm"
      >
        <div
          className="ant-collapse ant-collapse-icon-position-left sc-kAzzGY itTQAx"
          role={null}
          style={
    at Object.<anonymous> (/work/web/cashtab/src/components/Send/__tests__/Send.test.js:46:18)
    at Promise.then.completed (/work/web/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/web/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
    at _runTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/web/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/web/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/web/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)
====== CashTab Unit Tests:  Wallet with BCH balances ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet with BCH balances 1`

- Snapshot  - 3
+ Received  + 3

@@ -377,11 +377,11 @@
              >
                Send
              </button>
            </div>
            <div
-             className="sc-bRBYWo kDCtna"
+             className="sc-bRBYWo fNHvEm"
            >
              <div
                className="ant-collapse ant-collapse-icon-position-left sc-kAzzGY itTQAx"
                role={null}
                style={
@@ -433,11 +433,11 @@
            </div>
          </form>
        </div>
      </div>
      <div
-       className="sc-bRBYWo kDCtna"
+       className="sc-bRBYWo fNHvEm"
      >
        <div
          className="ant-collapse ant-collapse-icon-position-left sc-kAzzGY itTQAx"
          role={null}
          style={
@@ -486,11 +486,11 @@
            </div>
          </div>
        </div>
      </div>
      <div
-       className="sc-bRBYWo kDCtna"
+       className="sc-bRBYWo fNHvEm"
      >
        <div
          className="ant-collapse ant-collapse-icon-position-left sc-kAzzGY itTQAx"
          role={null}
          style={
    at Object.<anonymous> (/work/web/cashtab/src/components/Send/__tests__/Send.test.js:61:18)
    at Promise.then.completed (/work/web/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/web/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
    at _runTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/web/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/web/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/web/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)
====== CashTab Unit Tests:  Wallet with BCH balances and tokens ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet with BCH balances and tokens 1`

- Snapshot  - 3
+ Received  + 3

@@ -377,11 +377,11 @@
              >
                Send
              </button>
            </div>
            <div
-             className="sc-bRBYWo kDCtna"
+             className="sc-bRBYWo fNHvEm"
            >
              <div
                className="ant-collapse ant-collapse-icon-position-left sc-kAzzGY itTQAx"
                role={null}
                style={
@@ -433,11 +433,11 @@
            </div>
          </form>
        </div>
      </div>
      <div
-       className="sc-bRBYWo kDCtna"
+       className="sc-bRBYWo fNHvEm"
      >
        <div
          className="ant-collapse ant-collapse-icon-position-left sc-kAzzGY itTQAx"
          role={null}
          style={
@@ -486,11 +486,11 @@
            </div>
          </div>
        </div>
      </div>
      <div
-       className="sc-bRBYWo kDCtna"
+       className="sc-bRBYWo fNHvEm"
      >
        <div
          className="ant-collapse ant-collapse-icon-position-left sc-kAzzGY itTQAx"
          role={null}
          style={
    at Object.<anonymous> (/work/web/cashtab/src/components/Send/__tests__/Send.test.js:76:18)
    at Promise.then.completed (/work/web/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/web/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
    at _runTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/web/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/web/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/web/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)
====== CashTab Unit Tests:  Wallet with BCH balances and tokens and state field ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet with BCH balances and tokens and state field 1`

- Snapshot  - 3
+ Received  + 3

@@ -377,11 +377,11 @@
              >
                Send
              </button>
            </div>
            <div
-             className="sc-bRBYWo kDCtna"
+             className="sc-bRBYWo fNHvEm"
            >
              <div
                className="ant-collapse ant-collapse-icon-position-left sc-kAzzGY itTQAx"
                role={null}
                style={
@@ -433,11 +433,11 @@
            </div>
          </form>
        </div>
      </div>
      <div
-       className="sc-bRBYWo kDCtna"
+       className="sc-bRBYWo fNHvEm"
      >
        <div
          className="ant-collapse ant-collapse-icon-position-left sc-kAzzGY itTQAx"
          role={null}
          style={
@@ -486,11 +486,11 @@
            </div>
          </div>
        </div>
      </div>
      <div
-       className="sc-bRBYWo kDCtna"
+       className="sc-bRBYWo fNHvEm"
      >
        <div
          className="ant-collapse ant-collapse-icon-position-left sc-kAzzGY itTQAx"
          role={null}
          style={
    at Object.<anonymous> (/work/web/cashtab/src/components/Send/__tests__/Send.test.js:93:18)
    at Promise.then.completed (/work/web/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/web/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
    at _runTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/web/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/web/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/web/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)
====== CashTab Unit Tests:  Without wallet defined ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Without wallet defined 1`

- Snapshot  - 3
+ Received  + 3

@@ -372,11 +372,11 @@
              >
                Send
              </button>
            </div>
            <div
-             className="sc-bRBYWo kDCtna"
+             className="sc-bRBYWo fNHvEm"
            >
              <div
                className="ant-collapse ant-collapse-icon-position-left sc-kAzzGY itTQAx"
                role={null}
                style={
@@ -428,11 +428,11 @@
            </div>
          </form>
        </div>
      </div>
      <div
-       className="sc-bRBYWo kDCtna"
+       className="sc-bRBYWo fNHvEm"
      >
        <div
          className="ant-collapse ant-collapse-icon-position-left sc-kAzzGY itTQAx"
          role={null}
          style={
@@ -481,11 +481,11 @@
            </div>
          </div>
        </div>
      </div>
      <div
-       className="sc-bRBYWo kDCtna"
+       className="sc-bRBYWo fNHvEm"
      >
        <div
          className="ant-collapse ant-collapse-icon-position-left sc-kAzzGY itTQAx"
          role={null}
          style={
    at Object.<anonymous> (/work/web/cashtab/src/components/Send/__tests__/Send.test.js:113:18)
    at Promise.then.completed (/work/web/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/web/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
    at _runTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/web/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/web/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/web/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)

Each failure log is accessible here:
CashTab Unit Tests: Wallet without BCH balance
CashTab Unit Tests: Wallet with BCH balances
CashTab Unit Tests: Wallet with BCH balances and tokens
CashTab Unit Tests: Wallet with BCH balances and tokens and state field
CashTab Unit Tests: Without wallet defined

bytesofman requested changes to this revision.Apr 6 2022, 17:19

Since this fix is repeated across multiple components, please define this component in StyledCollapse and export it to Send.

Also, apply this fix to the collapse menu in Airdrop.js.

The custom component should look something like

export const CustomCollapseCtn = ({class, key, children}) => {
return (
<CollapseCtn>
                    <AdvancedCollapse
                        style={{
                            marginBottom: '24px',
                        }}
                    >
                        <Panel
                            header={
                                <div className={class}>
                                    Verify Message
                                </div>
                            }
                            key={key}
                        >
{children}
</CollapseCtn>);
};
This revision now requires changes to proceed.Apr 6 2022, 17:19
kieran709 updated this revision to Diff 33114.Apr 7 2022, 15:41

Responding to review feedback, added CustomCollapseContainer to StyledCollapse, replace the 3 collapses in Send.js and 1 in Airdrop.js with the new component.

Harbormaster completed remote builds in B18756: Diff 33114.Apr 7 2022, 15:44
bytesofman requested changes to this revision.Apr 8 2022, 11:20
bytesofman added inline comments.
web/cashtab/src/components/Common/StyledCollapse.js
113 ↗(On Diff #33114)

See T2382

These components do not need the key parameter.

It's okay to just drop it here.

138 ↗(On Diff #33114)

remove key

web/cashtab/src/components/Send/Send.js
961 ↗(On Diff #33114)

What's the purpose of this className?

1081 ↗(On Diff #33114)

What's the purpose of this className?

1172 ↗(On Diff #33114)

What's the purpose of this className?

This revision now requires changes to proceed.Apr 8 2022, 11:20
kieran709 updated this revision to Diff 33122.Apr 8 2022, 15:08

Responding to review feedback.

Harbormaster completed remote builds in B18760: Diff 33122.Apr 8 2022, 15:11
kieran709 added a comment.Apr 13 2022, 12:22

Having spent more time with this, I am fairly confident that the options are to:
A. use a className to keep the arrow icon on the left of the collapse and move the Panel Header to the center or
B. Center the Panel Header and the arrow icon

As far as I can tell, there is no way to select just the text without using some kind of selector, whether it is a className or an element . Let me know how you would like me to proceed!

bytesofman requested changes to this revision.Apr 14 2022, 09:23
bytesofman added inline comments.
web/cashtab/src/components/Airdrop/Airdrop.js
526 ↗(On Diff #33122)

Remove leading space

This revision now requires changes to proceed.Apr 14 2022, 09:23
kieran709 updated this revision to Diff 33226.Apr 14 2022, 14:38

responding to review feedback

Harbormaster completed remote builds in B18830: Diff 33226.Apr 14 2022, 14:41
teamcity added a comment.Apr 14 2022, 14:41
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests:  Wallet without BCH balance ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet without BCH balance 1`

- Snapshot  - 1
+ Received  + 1

@@ -74,11 +74,11 @@
                    </span>
                  </div>
                  <div
                    className="centeredTitleCollapse"
                  >
-                    XEC Airdrop Calculator
+                   XEC Airdrop Calculator
                  </div>
                </div>
              </div>
            </div>
          </div>
    at Object.<anonymous> (/work/web/cashtab/src/components/Airdrop/__tests__/Airdrop.test.js:46:18)
    at Promise.then.completed (/work/web/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/web/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
    at _runTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/web/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/web/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/web/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)
====== CashTab Unit Tests:  Wallet with BCH balances ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet with BCH balances 1`

- Snapshot  - 1
+ Received  + 1

@@ -74,11 +74,11 @@
                    </span>
                  </div>
                  <div
                    className="centeredTitleCollapse"
                  >
-                    XEC Airdrop Calculator
+                   XEC Airdrop Calculator
                  </div>
                </div>
              </div>
            </div>
          </div>
    at Object.<anonymous> (/work/web/cashtab/src/components/Airdrop/__tests__/Airdrop.test.js:61:18)
    at Promise.then.completed (/work/web/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/web/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
    at _runTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/web/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/web/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/web/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)
====== CashTab Unit Tests:  Wallet with BCH balances and tokens ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet with BCH balances and tokens 1`

- Snapshot  - 1
+ Received  + 1

@@ -74,11 +74,11 @@
                    </span>
                  </div>
                  <div
                    className="centeredTitleCollapse"
                  >
-                    XEC Airdrop Calculator
+                   XEC Airdrop Calculator
                  </div>
                </div>
              </div>
            </div>
          </div>
    at Object.<anonymous> (/work/web/cashtab/src/components/Airdrop/__tests__/Airdrop.test.js:76:18)
    at Promise.then.completed (/work/web/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/web/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
    at _runTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/web/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/web/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/web/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)
====== CashTab Unit Tests:  Wallet with BCH balances and tokens and state field ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet with BCH balances and tokens and state field 1`

- Snapshot  - 1
+ Received  + 1

@@ -73,11 +73,11 @@
                    </span>
                  </div>
                  <div
                    className="centeredTitleCollapse"
                  >
-                    XEC Airdrop Calculator
+                   XEC Airdrop Calculator
                  </div>
                </div>
              </div>
            </div>
          </div>
    at Object.<anonymous> (/work/web/cashtab/src/components/Airdrop/__tests__/Airdrop.test.js:93:18)
    at Promise.then.completed (/work/web/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/web/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
    at _runTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/web/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/web/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/web/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)
====== CashTab Unit Tests:  Without wallet defined ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Without wallet defined 1`

- Snapshot  - 1
+ Received  + 1

@@ -69,11 +69,11 @@
                    </span>
                  </div>
                  <div
                    className="centeredTitleCollapse"
                  >
-                    XEC Airdrop Calculator
+                   XEC Airdrop Calculator
                  </div>
                </div>
              </div>
            </div>
          </div>
    at Object.<anonymous> (/work/web/cashtab/src/components/Airdrop/__tests__/Airdrop.test.js:113:18)
    at Promise.then.completed (/work/web/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/web/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
    at _runTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/web/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/web/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/web/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)

Each failure log is accessible here:
CashTab Unit Tests: Wallet without BCH balance
CashTab Unit Tests: Wallet with BCH balances
CashTab Unit Tests: Wallet with BCH balances and tokens
CashTab Unit Tests: Wallet with BCH balances and tokens and state field
CashTab Unit Tests: Without wallet defined

bytesofman requested changes to this revision.Apr 20 2022, 17:07

Rebase to latest master and run npm test to update snapshots

This revision now requires changes to proceed.Apr 20 2022, 17:07
kieran709 updated this revision to Diff 33317.Apr 26 2022, 17:30

updated snapshots

Harbormaster completed remote builds in B18893: Diff 33317.Apr 26 2022, 17:33
bytesofman requested changes to this revision.Apr 26 2022, 21:02
bytesofman added inline comments.
web/cashtab/src/components/Airdrop/Airdrop.js
526 ↗(On Diff #33317)

does this still match previous functionality without the defaultActiveKey param?

Please include this param. Need to pass it down to the AdvancedCollapse child component in CustomCollapseContainer

web/cashtab/src/components/Send/Send.js
967 ↗(On Diff #33317)

does this still match previous functionality without the defaultActiveKey param?

Please include this param. Need to pass it down to the AdvancedCollapse child component in CustomCollapseContainer

This revision now requires changes to proceed.Apr 26 2022, 21:02
kieran709 updated this revision to Diff 33344.Apr 28 2022, 15:42

Responding to review feedback + rebased & updated snapshots

Harbormaster completed remote builds in B18906: Diff 33344.Apr 28 2022, 15:55
bytesofman requested changes to this revision.Apr 28 2022, 19:43
bytesofman added inline comments.
web/cashtab/src/components/Common/StyledCollapse.js
128 ↗(On Diff #33344)

Use a styled component for this div instead of className

142 ↗(On Diff #33344)

Looks like options are ['0'] or ['1']

From antd, https://ant.design/components/collapse/

Types are either array of string or array of number

Since we are using the string here, can just list that.

PropTypes.arrayOf(PropTypes.string)

see https://reactjs.org/docs/typechecking-with-proptypes.html

This revision now requires changes to proceed.Apr 28 2022, 19:43
kieran709 updated this revision to Diff 33363.May 2 2022, 15:55

Responding to review feedback

Harbormaster completed remote builds in B18919: Diff 33363.May 2 2022, 15:58
teamcity added a comment.May 2 2022, 15:58
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests:  Wallet without BCH balance ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet without BCH balance 1`

- Snapshot  - 1
+ Received  + 1

@@ -72,11 +72,11 @@
                        />
                      </svg>
                    </span>
                  </div>
                  <div
-                   className="sc-chPdSV AGhxe"
+                   className="sc-chPdSV byfFmt"
                  >
                    XEC Airdrop Calculator
                  </div>
                </div>
              </div>
    at Object.<anonymous> (/work/web/cashtab/src/components/Airdrop/__tests__/Airdrop.test.js:46:18)
    at Promise.then.completed (/work/web/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/web/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
    at _runTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/web/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/web/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/web/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet without BCH balance 1`

- Snapshot  - 3
+ Received  + 3

@@ -421,11 +421,11 @@
                          />
                        </svg>
                      </span>
                    </div>
                    <div
-                     className="sc-chPdSV AGhxe"
+                     className="sc-chPdSV byfFmt"
                    >
                      Advanced
                    </div>
                  </div>
                </div>
@@ -477,11 +477,11 @@
                    />
                  </svg>
                </span>
              </div>
              <div
-               className="sc-chPdSV AGhxe"
+               className="sc-chPdSV byfFmt"
              >
                Sign Message
              </div>
            </div>
          </div>
@@ -530,11 +530,11 @@
                    />
                  </svg>
                </span>
              </div>
              <div
-               className="sc-chPdSV AGhxe"
+               className="sc-chPdSV byfFmt"
              >
                Verify Message
              </div>
            </div>
          </div>
    at Object.<anonymous> (/work/web/cashtab/src/components/Send/__tests__/Send.test.js:46:18)
    at Promise.then.completed (/work/web/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/web/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
    at _runTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/web/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/web/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/web/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)
====== CashTab Unit Tests:  Wallet with BCH balances ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet with BCH balances 1`

- Snapshot  - 1
+ Received  + 1

@@ -72,11 +72,11 @@
                        />
                      </svg>
                    </span>
                  </div>
                  <div
-                   className="sc-chPdSV AGhxe"
+                   className="sc-chPdSV byfFmt"
                  >
                    XEC Airdrop Calculator
                  </div>
                </div>
              </div>
    at Object.<anonymous> (/work/web/cashtab/src/components/Airdrop/__tests__/Airdrop.test.js:61:18)
    at Promise.then.completed (/work/web/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/web/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
    at _runTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/web/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/web/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/web/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet with BCH balances 1`

- Snapshot  - 3
+ Received  + 3

@@ -421,11 +421,11 @@
                          />
                        </svg>
                      </span>
                    </div>
                    <div
-                     className="sc-chPdSV AGhxe"
+                     className="sc-chPdSV byfFmt"
                    >
                      Advanced
                    </div>
                  </div>
                </div>
@@ -477,11 +477,11 @@
                    />
                  </svg>
                </span>
              </div>
              <div
-               className="sc-chPdSV AGhxe"
+               className="sc-chPdSV byfFmt"
              >
                Sign Message
              </div>
            </div>
          </div>
@@ -530,11 +530,11 @@
                    />
                  </svg>
                </span>
              </div>
              <div
-               className="sc-chPdSV AGhxe"
+               className="sc-chPdSV byfFmt"
              >
                Verify Message
              </div>
            </div>
          </div>
    at Object.<anonymous> (/work/web/cashtab/src/components/Send/__tests__/Send.test.js:61:18)
    at Promise.then.completed (/work/web/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/web/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
    at _runTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/web/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/web/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/web/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)
====== CashTab Unit Tests:  Wallet with BCH balances and tokens ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet with BCH balances and tokens 1`

- Snapshot  - 1
+ Received  + 1

@@ -72,11 +72,11 @@
                        />
                      </svg>
                    </span>
                  </div>
                  <div
-                   className="sc-chPdSV AGhxe"
+                   className="sc-chPdSV byfFmt"
                  >
                    XEC Airdrop Calculator
                  </div>
                </div>
              </div>
    at Object.<anonymous> (/work/web/cashtab/src/components/Airdrop/__tests__/Airdrop.test.js:76:18)
    at Promise.then.completed (/work/web/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/web/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
    at _runTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/web/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/web/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/web/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet with BCH balances and tokens 1`

- Snapshot  - 3
+ Received  + 3

@@ -421,11 +421,11 @@
                          />
                        </svg>
                      </span>
                    </div>
                    <div
-                     className="sc-chPdSV AGhxe"
+                     className="sc-chPdSV byfFmt"
                    >
                      Advanced
                    </div>
                  </div>
                </div>
@@ -477,11 +477,11 @@
                    />
                  </svg>
                </span>
              </div>
              <div
-               className="sc-chPdSV AGhxe"
+               className="sc-chPdSV byfFmt"
              >
                Sign Message
              </div>
            </div>
          </div>
@@ -530,11 +530,11 @@
                    />
                  </svg>
                </span>
              </div>
              <div
-               className="sc-chPdSV AGhxe"
+               className="sc-chPdSV byfFmt"
              >
                Verify Message
              </div>
            </div>
          </div>
    at Object.<anonymous> (/work/web/cashtab/src/components/Send/__tests__/Send.test.js:76:18)
    at Promise.then.completed (/work/web/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/web/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
    at _runTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/web/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/web/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/web/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)
====== CashTab Unit Tests:  Wallet with BCH balances and tokens and state field ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet with BCH balances and tokens and state field 1`

- Snapshot  - 1
+ Received  + 1

@@ -71,11 +71,11 @@
                        />
                      </svg>
                    </span>
                  </div>
                  <div
-                   className="sc-chPdSV AGhxe"
+                   className="sc-chPdSV byfFmt"
                  >
                    XEC Airdrop Calculator
                  </div>
                </div>
              </div>
    at Object.<anonymous> (/work/web/cashtab/src/components/Airdrop/__tests__/Airdrop.test.js:93:18)
    at Promise.then.completed (/work/web/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/web/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
    at _runTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/web/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/web/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/web/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet with BCH balances and tokens and state field 1`

- Snapshot  - 3
+ Received  + 3

@@ -421,11 +421,11 @@
                          />
                        </svg>
                      </span>
                    </div>
                    <div
-                     className="sc-chPdSV AGhxe"
+                     className="sc-chPdSV byfFmt"
                    >
                      Advanced
                    </div>
                  </div>
                </div>
@@ -477,11 +477,11 @@
                    />
                  </svg>
                </span>
              </div>
              <div
-               className="sc-chPdSV AGhxe"
+               className="sc-chPdSV byfFmt"
              >
                Sign Message
              </div>
            </div>
          </div>
@@ -530,11 +530,11 @@
                    />
                  </svg>
                </span>
              </div>
              <div
-               className="sc-chPdSV AGhxe"
+               className="sc-chPdSV byfFmt"
              >
                Verify Message
              </div>
            </div>
          </div>
    at Object.<anonymous> (/work/web/cashtab/src/components/Send/__tests__/Send.test.js:93:18)
    at Promise.then.completed (/work/web/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/web/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
    at _runTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/web/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/web/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/web/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)
====== CashTab Unit Tests:  Without wallet defined ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Without wallet defined 1`

- Snapshot  - 1
+ Received  + 1

@@ -67,11 +67,11 @@
                        />
                      </svg>
                    </span>
                  </div>
                  <div
-                   className="sc-chPdSV AGhxe"
+                   className="sc-chPdSV byfFmt"
                  >
                    XEC Airdrop Calculator
                  </div>
                </div>
              </div>
    at Object.<anonymous> (/work/web/cashtab/src/components/Airdrop/__tests__/Airdrop.test.js:113:18)
    at Promise.then.completed (/work/web/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/web/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
    at _runTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/web/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/web/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/web/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)Error: expect(received).toMatchSnapshot()

Snapshot name: `Without wallet defined 1`

- Snapshot  - 3
+ Received  + 3

@@ -416,11 +416,11 @@
                          />
                        </svg>
                      </span>
                    </div>
                    <div
-                     className="sc-chPdSV AGhxe"
+                     className="sc-chPdSV byfFmt"
                    >
                      Advanced
                    </div>
                  </div>
                </div>
@@ -472,11 +472,11 @@
                    />
                  </svg>
                </span>
              </div>
              <div
-               className="sc-chPdSV AGhxe"
+               className="sc-chPdSV byfFmt"
              >
                Sign Message
              </div>
            </div>
          </div>
@@ -525,11 +525,11 @@
                    />
                  </svg>
                </span>
              </div>
              <div
-               className="sc-chPdSV AGhxe"
+               className="sc-chPdSV byfFmt"
              >
                Verify Message
              </div>
            </div>
          </div>
    at Object.<anonymous> (/work/web/cashtab/src/components/Send/__tests__/Send.test.js:113:18)
    at Promise.then.completed (/work/web/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/web/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
    at _runTest (/work/web/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/web/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/web/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/web/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/web/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/web/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)

Each failure log is accessible here:
CashTab Unit Tests: Wallet without BCH balance
CashTab Unit Tests: Wallet with BCH balances
CashTab Unit Tests: Wallet with BCH balances and tokens
CashTab Unit Tests: Wallet with BCH balances and tokens and state field
CashTab Unit Tests: Without wallet defined

bytesofman requested changes to this revision.May 2 2022, 16:20

Update snapshots

This revision now requires changes to proceed.May 2 2022, 16:20
kieran709 updated this revision to Diff 33370.May 2 2022, 22:44

updated snapshots

Harbormaster completed remote builds in B18926: Diff 33370.May 2 2022, 22:47
bytesofman accepted this revision.May 2 2022, 23:41
This revision is now accepted and ready to land.May 2 2022, 23:41
Closed by commit rABC530a41fbf048: [Cashtab] Center collapse headers in Send.js (authored by kieran709). · Explain WhyMay 3 2022, 14:40
This revision was automatically updated to reflect the committed changes.
kieran709 added a commit: rABC530a41fbf048: [Cashtab] Center collapse headers in Send.js.

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
components/
Send/
345 lines
__tests__/
__snapshots__/

Diff 33107

View Options

web/cashtab/src/components/Send/Send.js

Loading...
View Options

web/cashtab/src/components/Send/__tests__/__snapshots__/Send.test.js.snap

Loading...