Page MenuHomePhabricator
Differential D11319

[test] remove unnecessary transaction rehashing
ClosedPublic
Actions

Authored by PiRK on Apr 8 2022, 08:07.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCf2403c070739: [test] remove unnecessary transaction rehashing
Summary

The create_coinbase function already calls CTransaction.calc_sha256() immediately prior to returning the transaction, so it is not necessary to call CTransaction.rehash() if the transaction is not modified.

Test Plan

test/functional/test_runner.py abc*

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Apr 8 2022, 08:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 8 2022, 08:07
PiRK requested review of this revision.Apr 8 2022, 08:07
Harbormaster completed remote builds in B18757: Diff 33115.Apr 8 2022, 08:25
PiRK retitled this revision from [test]remove unnecessary transaction rehashing to [test] remove unnecessary transaction rehashing.Apr 8 2022, 08:41
Fabien accepted this revision.Apr 8 2022, 09:17
This revision is now accepted and ready to land.Apr 8 2022, 09:17
Closed by commit rABCf2403c070739: [test] remove unnecessary transaction rehashing (authored by PiRK). · Explain WhyApr 8 2022, 14:03
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCf2403c070739: [test] remove unnecessary transaction rehashing.

Revision Contents
Changeset List

Diff 33120

View Options

test/functional/abc-invalid-chains.py

Loading...
View Options

test/functional/abc-replay-protection.py

Loading...
View Options

test/functional/abc-segwit-recovery.py

Loading...
View Options

test/functional/abc-transaction-ordering.py

Loading...
View Options

test/functional/abc_p2p_compactblocks.py

Loading...
View Options

test/functional/abc_p2p_fullblocktest.py

Loading...