HomePhabricator

[test] remove unnecessary transaction rehashing

Description

[test] remove unnecessary transaction rehashing

Summary: The create_coinbase function already calls CTransaction.calc_sha256() immediately prior to returning the transaction, so it is not necessary to call CTransaction.rehash() if the transaction is not modified.

Test Plan: test/functional/test_runner.py abc*

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D11319

Details

Provenance
PiRKAuthored on Apr 8 2022, 08:03
PiRKPushed on Apr 8 2022, 14:03
Reviewer
Restricted Project
Differential Revision
D11319: [test] remove unnecessary transaction rehashing
Parents
rABCfa4487a9c43d: [Cashtab] adjust airdrop totalHolders type
Branches
Unknown
Tags
Unknown